fix: add message queue with retry for addon sync in Interrupts and De…#26
Merged
fix: add message queue with retry for addon sync in Interrupts and De…#26
Conversation
…fensives In WoW 12.0 (Midnight), SendAddonMessage can return AddOnMessageLockdown or AddonMessageThrottle during instanced combat, silently dropping messages. SYNC messages survive because the heartbeat fires between pulls, but USED messages (sent during combat) are lost. Changes: - Replace fire-and-forget safeSend with queue + retry system in both addons - Check SendAddonMessage return value; queue failed messages - OnUpdate ticker only runs when queue is non-empty (start/stop pattern) - Retry queued messages every 1s, discard after 30s - Separate expiry pruning from send pass in flushQueue - Include GetServerTime() timestamp in USED messages so receivers can adjust cooldown remaining for delivery delay - Always update charge state even when remaining <= 0 (Defensives) - Remove pcall wrapping (API returns error codes, not exceptions) - Remove spurious early-return guard in Defensives ModernDefensivesDisplay - Localize table.remove for hot-path usage - Backward-compatible: receivers handle both old (no timestamp) and new formats - Bump Interrupts to 2.2.0, Defensives to 2.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WoW 12.0 (Midnight), SendAddonMessage can return AddOnMessageLockdown or AddonMessageThrottle during instanced combat, silently dropping messages. SYNC messages survive because the heartbeat fires between pulls, but USED messages (sent during combat) are lost.
Changes: