Skip to content

feat: Handle Double Priest Pain Sup + Filter Personal Externals Option#27

Merged
loicngr merged 2 commits intoloicngr:mainfrom
bjth:main
Apr 2, 2026
Merged

feat: Handle Double Priest Pain Sup + Filter Personal Externals Option#27
loicngr merged 2 commits intoloicngr:mainfrom
bjth:main

Conversation

@bjth
Copy link
Copy Markdown
Contributor

@bjth bjth commented Apr 2, 2026

Hi, not sure if you are looking for contributions.
But while testing the addon, we noticed that double pain suppression talent was not being honored, so this has a fix for that.
Also our raid leader had a request to hide his own externals but keep tracking the healers, so added an option for that.

@loicngr loicngr self-requested a review April 2, 2026 09:47
@loicngr loicngr assigned loicngr and bjth and unassigned loicngr Apr 2, 2026
@loicngr loicngr added the enhancement New feature or request label Apr 2, 2026
@loicngr
Copy link
Copy Markdown
Owner

loicngr commented Apr 2, 2026

Hi, not sure if you are looking for contributions. But while testing the addon, we noticed that double pain suppression talent was not being honored, so this has a fix for that. Also our raid leader had a request to hide his own externals but keep tracking the healers, so added an option for that.

Hello, thank you for your contribution.
I'll take a look at it during my lunch break.

Copy link
Copy Markdown
Owner

@loicngr loicngr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me. Can you manually update the version in ZaeUI_Defensives.toc to 2.3.2? @bjth

@bjth
Copy link
Copy Markdown
Contributor Author

bjth commented Apr 2, 2026

@loicngr done, sorry for the delay, was out and about.

@loicngr loicngr merged commit 45120ff into loicngr:main Apr 2, 2026
1 check passed
@loicngr
Copy link
Copy Markdown
Owner

loicngr commented Apr 2, 2026

@loicngr done, sorry for the delay, was out and about.

No problem, thanks.
Release was automatically created and published on CurseForge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants