fix: add mutex to Owner for goroutine-safe linked list operations #1
Merged
AnatoleLucet merged 1 commit intoloom-go:mainfrom Mar 27, 2026
Merged
Conversation
5f33e68 to
dd62b97
Compare
dd62b97 to
71cf04f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix data race in
Ownerlinked list when signals are written from a different goroutine than the one that created the reactive graph.Root:
AddChild,DisposeChildren,OnCleanup,OnError, and context map access had no synchronization. WhenSignal.Writefrom goroutine B triggersrecomputeof a node created on goroutine A, new children are added to A's owner tree concurrently — corrupting the doubly-linked list (infinite loop → freeze).Fix: Add
sync.MutextoOwnerwith snapshot-then-release pattern — lock to snapshot/detach, unlock before executing callbacks or disposing children. No deadlocks: parent lock is always released before acquiring child locks.