This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix(api): standardize work submission response field naming#1
Merged
mdlopresti merged 2 commits intomainfrom Dec 18, 2025
Merged
fix(api): standardize work submission response field naming#1mdlopresti merged 2 commits intomainfrom
mdlopresti merged 2 commits intomainfrom
Conversation
added 2 commits
December 18, 2025 07:43
Add standard 'id' field to WorkSubmitResponse while maintaining backward compatibility with 'workItemId'. This resolves the API field naming inconsistency identified in integration testing. Changes: - Add 'id' field as the primary work item identifier - Keep 'workItemId' field with @deprecated annotation - Update coordinator to return both fields in response - No breaking changes - existing clients using 'workItemId' continue to work Related: test-scenarios/WEFT-INTEGRATION-TEST-SUMMARY.md (REQ-ROUTE-001) Priority: P2 - Documentation/consistency improvement Verified: - All existing tests pass (72 tests) - TypeScript type checking passes - Build succeeds
Use correct package names @loominal/shared and @loominal/weft instead of @loom/shared and @loom/weft in pnpm filter commands. This fixes the docker-weft CI build failure where dist directories were not being created because the build commands were not matching any packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds standard
idfield toWorkSubmitResponsewhile maintaining backward compatibility withworkItemId. This resolves the API field naming inconsistency identified in integration testing.Changes
idfield as the primary work item identifierworkItemIdfield with@deprecatedannotationworkItemIdcontinue to workTesting
Integration Tests: ✅ PASSING
Unit Tests:
API Response Example
{ "id": "f01434ce-4db6-4be6-8827-cdeb1204a8c8", "workItemId": "f01434ce-4db6-4be6-8827-cdeb1204a8c8", "targetAgentType": "claude-code", "spinUpTriggered": true, "estimatedWaitSeconds": 30 }Related Issues
test-scenarios/WEFT-INTEGRATION-TEST-SUMMARY.mdMigration Path
For API consumers:
idinstead ofworkItemIdworkItemIdmay be removed in future major versionFiles Changed
shared/src/types/work-item.ts(+3 lines)weft/src/coordinator/coordinator.ts(+1 line)