Update withdrawal limit warning messages and error messages #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enlight
requested changes
Jun 17, 2021
src/store/gateway/plasma.ts
Outdated
| } | ||
| feedback.endTask() | ||
| feedback.showError(i18n.t("feedback_msg.error.withdraw_failed").toString()) | ||
| if (error.message.includes("limit reached")) { |
Contributor
There was a problem hiding this comment.
Gateway errors have codes (TGXXX), match those, not the description:
TG024: total daily withdrawal limit reachedTG025: account daily withdrawal limit reached
| this.visible = false | ||
| } | ||
| reachedLimit() { |
Contributor
There was a problem hiding this comment.
This function doesn't mutate any state, so it should just be a getter
| <h6 v-if="isWithdrawalLimitEnabled && isCheckDailyRemainingWithdrawAmount()"> | ||
| <h6 v-if="reachedLimit()"> | ||
| {{ $t('components.gateway.withdraw_form_modal.daily_withdrawal_limit_reached') }} | ||
| {{ isWithdrawalLimitEnabled | tokenAmount(tokenInfo.decimals) }} {{ token }} |
Contributor
There was a problem hiding this comment.
This doesn't make sense, isWithdrawalLimitEnabled returns a boolean, how is that going to render an amount?
| {{ $t('components.gateway.withdraw_form_modal.daily_remaining_withdraw_amount') }} | ||
| {{ dailyRemainingWithdrawAmount | tokenAmount(tokenInfo.decimals) }} {{ token }} | ||
| {{ dailyRemainingWithdrawAmount | tokenAmount(tokenInfo.decimals) }} / | ||
| {{ isWithdrawalLimitEnabled | tokenAmount(tokenInfo.decimals) }} {{ token }} |
Contributor
|
Closed in favor of #1466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues
#1461
#1462
#1463