Merged
Conversation
- Extract duplicated expired-reservation cleanup into `deleteExpiredReservations` - Reuse existing `mapReservationRecord` in `getReservations` instead of manual reconstruction with unnecessary type cast - Simplify `.filter((x) => Boolean(x))` to `.filter(Boolean)` for consistency with rest of codebase Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove three unused methods from LootMappingService: - sortNpcsByWt: never called (processNpcs already sorts) - mapNpcs: never called externally (processNpcs.mapped covers this) - mapLootShare: never called anywhere in the codebase Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ently - Extract shared date validation logic in event-hero-kill-job.ts into a single `parseDate` helper, removing duplication between `toRequiredDate` and `toOptionalDate` - Replace inline OWNER/ADMIN permission check in can-view-event-hero.ts with `PermissionResolver.isAdministrative()` for consistency Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use `import type` for type-only imports in use-chat-cache.ts and session.middleware.ts - Rename catch parameter `err` to `error` in use-margo-event.ts per unicorn/catch-error-name Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ndant Date constructor Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
scoring-time.util.ts and notification-schedule-time.util.ts contained ~100 lines of identical timezone conversion code (createCachedFormatter, getPartValue, getLocalDate, getTimeZoneOffsetMinutes, toUtcDateFromLocal, addDays, LocalDate type). Extracted to shared/utils/timezone.util.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extract clipToWindow and clipToWindowSeconds into tracking-window.util.ts, replacing private implementations in event-summary.service.ts and event-wrapped.service.ts that duplicated the same clipping logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bumps node from 25.8.2-alpine3.22 to 25.9.0-alpine3.22. --- updated-dependencies: - dependency-name: node dependency-version: 25.9.0-alpine3.22 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Event NPCs hotfixes
feat: api migration to zod
Remove no-op console.log("onSuccess") and console.log("onError")
callbacks from useDeleteTimer, useResetTimer, and useUpdateLoot hooks.
These were leftover development placeholders with no functional purpose.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bumps the npm_and_yarn group with 1 update in the /.agents/skills/brainstorming/scripts directory: [path-to-regexp](https://github.com/pillarjs/path-to-regexp). Updates `path-to-regexp` from 0.1.12 to 0.1.13 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/v.0.1.13/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.12...v.0.1.13) --- updated-dependencies: - dependency-name: path-to-regexp dependency-version: 0.1.13 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Combine identical SET_BASE and ADD_BONUS branches in formatScoringAction, and use ES6 shorthand for hid property in loot query service. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ckage Feature/margonem types shared package
- Remove redundant `totalDurationMs <= 0` guard in scoring-engine.util.ts (already covered by `killTime <= respawnStartTime` check above) - Remove unnecessary `as EventScoringRules["rules"]` type assertion in scoring-rules.util.ts (TS 5.5+ infers filter narrowing) - Deduplicate CLOCK_PATTERN regex from scoring-rules.util.ts and event-scoring-rules.dto.ts into scoring-rules.constant.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…-gateway-zod-migration feat: migrated to nestjs zod
…y with 8 updates Bumps the production-dependencies group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [discord-api-types](https://github.com/discordjs/discord-api-types) | `0.38.31` | `0.38.44` | | [dotenv](https://github.com/motdotla/dotenv) | `17.4.0` | `17.4.1` | | [nestjs-zod](https://github.com/BenLorantfy/nestjs-zod/tree/HEAD/packages/nestjs-zod) | `5.2.1` | `5.3.0` | | [better-auth](https://github.com/better-auth/better-auth/tree/HEAD/packages/better-auth) | `1.5.6` | `1.6.0` | | [hono](https://github.com/honojs/hono) | `4.12.10` | `4.12.11` | | [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) | `3.1024.0` | `3.1025.0` | | [react-hook-form](https://github.com/react-hook-form/react-hook-form) | `7.67.0` | `7.72.1` | | [meilisearch](https://github.com/meilisearch/meilisearch-js) | `0.56.0` | `0.57.0` | Updates `discord-api-types` from 0.38.31 to 0.38.44 - [Release notes](https://github.com/discordjs/discord-api-types/releases) - [Changelog](https://github.com/discordjs/discord-api-types/blob/main/CHANGELOG.md) - [Commits](discordjs/discord-api-types@0.38.31...0.38.44) Updates `dotenv` from 17.4.0 to 17.4.1 - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v17.4.0...v17.4.1) Updates `nestjs-zod` from 5.2.1 to 5.3.0 - [Release notes](https://github.com/BenLorantfy/nestjs-zod/releases) - [Commits](https://github.com/BenLorantfy/nestjs-zod/commits/v5.3.0/packages/nestjs-zod) Updates `better-auth` from 1.5.6 to 1.6.0 - [Release notes](https://github.com/better-auth/better-auth/releases) - [Changelog](https://github.com/better-auth/better-auth/blob/main/packages/better-auth/CHANGELOG.md) - [Commits](https://github.com/better-auth/better-auth/commits/better-auth@1.6.0/packages/better-auth) Updates `hono` from 4.12.10 to 4.12.11 - [Release notes](https://github.com/honojs/hono/releases) - [Commits](honojs/hono@v4.12.10...v4.12.11) Updates `@aws-sdk/client-s3` from 3.1024.0 to 3.1025.0 - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.1025.0/clients/client-s3) Updates `react-hook-form` from 7.67.0 to 7.72.1 - [Release notes](https://github.com/react-hook-form/react-hook-form/releases) - [Changelog](https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md) - [Commits](react-hook-form/react-hook-form@v7.67.0...v7.72.1) Updates `meilisearch` from 0.56.0 to 0.57.0 - [Release notes](https://github.com/meilisearch/meilisearch-js/releases) - [Commits](meilisearch/meilisearch-js@v0.56.0...v0.57.0) --- updated-dependencies: - dependency-name: discord-api-types dependency-version: 0.38.44 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies - dependency-name: dotenv dependency-version: 17.4.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies - dependency-name: nestjs-zod dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: better-auth dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: hono dependency-version: 4.12.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies - dependency-name: "@aws-sdk/client-s3" dependency-version: 3.1025.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: react-hook-form dependency-version: 7.72.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: meilisearch dependency-version: 0.57.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…ts/skills/brainstorming/scripts/npm_and_yarn-5c00e80ab5 chore(deps): bump path-to-regexp from 0.1.12 to 0.1.13 in /.agents/skills/brainstorming/scripts in the npm_and_yarn group across 1 directory
Bumps [i18next](https://github.com/i18next/i18next) from 25.10.10 to 26.0.2. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v25.10.10...v26.0.2) --- updated-dependencies: - dependency-name: i18next dependency-version: 26.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…1936 refactor: remove placeholder console.log from mutation hooks
…pine3.22 chore(deps): bump node from 25.8.2-alpine3.22 to 25.9.0-alpine3.22
refactor: clean up reservations service
…kit-1.0.0-beta.20 chore(deps-dev): bump drizzle-kit from 1.0.0-beta.19 to 1.0.0-beta.20
Enforce project convention (AGENTS.md) of preferring ?? over || for nullish coalescing across three game-client components. Also simplify a nested ternary in single-notification.tsx using ??. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
refactor: consolidate duplicated interval clipping utilities
refactor: simplify timer utils — extract NPC name helper, remove redundant Date constructor
refactor: fix type import and catch naming lint warnings
refactor: deduplicate date parsing and use PermissionResolver consistently
refactor: replace || with ?? for nullish coalescing in game-client
refactor: extract shared timezone utilities
refactor: remove dead code from LootMappingService
…26.0.2 chore(deps): bump i18next from 25.10.10 to 26.0.2
- Inline getGuildByIdInternal into getGuildById, removing unnecessary wrapper method - Rename misleading boolean `comparedGuilds` to `allGuildsInDiscord` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove misleading `await` on fire-and-forget `emitMessage` call (returns void, not Promise) - Extract duplicated 404 status check into `isNotFoundStatus` helper in DiscordService Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
refactor: small readability cleanups in chat and discord services
refactor: clean up GuildsService readability
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lootlog-docs | f8c52e1 | Commit Preview URL Branch Preview URL |
Apr 08 2026, 04:29 PM |
chore: bumped ts to v6
…n files Consistent with the pattern already applied in game-client (c88c278). Using ?? is more semantically correct for env var fallbacks since it only falls back on null/undefined, not empty strings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove `allGuildsInDiscord` checks in `getUserGuilds` and
`getCandidateGuildsForUser` — guilds are queried with
`id: { in: discordGuildIds }`, so the `.every()` always returns true
and the cache-clear block is unreachable.
Remove redundant `Array.isArray(userPreferences.guildsOrder)` check —
Prisma schema defines `guildsOrder` as `String[]`, guaranteeing it is
always an array when present.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
refactor: remove dead code and redundant condition in GuildsService
refactor: replace || with ?? in instrumentation files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.