Review: Security Review from Chad#1
Open
xhad wants to merge 1 commit intoeth-max-vault-release-candidatefrom
Open
Review: Security Review from Chad#1xhad wants to merge 1 commit intoeth-max-vault-release-candidatefrom
xhad wants to merge 1 commit intoeth-max-vault-release-candidatefrom
Conversation
|
thank you, reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey man, I ran a security skill and added tests for a few items. This is a folder int eh vault unit tests with a doc called
security-review.mdthat sets the prompt up for review. It saw a few things and generated some tests.Not entirely sure if these are true positives, but wanted to share here incase they are of interest.
Please ignore the
libdiffs and see:test/unit/vault/security/20260201/review-2026-02-01.md
test/unit/vault/security/20260201/README.md