refactor(k8s): restructure helm charts to k8s directory#1129
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes Kubernetes deployment assets by moving Helm charts under each app’s k8s/ directory and updates infrastructure docs to reference the new layout, aiming to keep application code and Kubernetes deployment concerns clearly separated.
Changes:
- Update Argo CD setup documentation to use
apps/<app>/k8s/chartand link to per-appk8s/README.mdguides. - Introduce/relocate Helm charts under
apps/{api,idem-admin,idem-idp}/k8s/chart. - Add per-app Kubernetes deployment READMEs under
apps/{api,idem-admin,idem-idp}/k8s/.
Reviewed changes
Copilot reviewed 8 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/infrastructure/argocd-setup.md | Updates Argo CD “path” and documentation links to new k8s/ structure. |
| apps/idem-idp/k8s/chart/Chart.yaml | Adds chart metadata for idem-idp under k8s/chart. |
| apps/idem-idp/k8s/chart/values.yaml | Defines idem-idp Helm values (notably DNS/service/image/resources). |
| apps/idem-idp/k8s/chart/templates/deployment.yaml | Adds idem-idp Deployment template. |
| apps/idem-idp/k8s/chart/templates/service.yaml | Adds idem-idp Service template. |
| apps/idem-idp/k8s/chart/templates/httproute.yaml | Adds idem-idp HTTPRoute template (Traefik Gateway API). |
| apps/idem-idp/k8s/chart/README.md | Documents idem-idp chart usage, values, secrets, and Argo CD setup. |
| apps/idem-idp/k8s/README.md | Adds idem-idp Kubernetes deployment guide at the app level. |
| apps/idem-admin/k8s/chart/Chart.yaml | Adds chart metadata for idem-admin under k8s/chart. |
| apps/idem-admin/k8s/chart/values.yaml | Defines idem-admin Helm values. |
| apps/idem-admin/k8s/chart/templates/deployment.yaml | Adds idem-admin Deployment template. |
| apps/idem-admin/k8s/chart/templates/service.yaml | Adds idem-admin Service template. |
| apps/idem-admin/k8s/chart/templates/httproute.yaml | Adds idem-admin HTTPRoute template (Traefik Gateway API). |
| apps/idem-admin/k8s/README.md | Adds idem-admin Kubernetes deployment guide at the app level. |
| apps/api/k8s/chart/Chart.yaml | Adds chart metadata for the Eventuras API under k8s/chart. |
| apps/api/k8s/chart/values.yaml | Defines API Helm values (image/dns/service/resources/healthCheck, etc.). |
| apps/api/k8s/chart/templates/deployment.yaml | Adds API Deployment template (incl. ASPNETCORE_URLS + probes). |
| apps/api/k8s/chart/templates/service.yaml | Adds API Service template. |
| apps/api/k8s/chart/templates/httproute.yaml | Adds API HTTPRoute template (Traefik Gateway API). |
| apps/api/k8s/chart/templates/certificate.yaml | Adds per-app cert-manager Certificate resource. |
| apps/api/k8s/chart/README.md | Documents API chart usage and required secret keys. |
| apps/api/k8s/README.md | Adds API Kubernetes deployment guide at the app level. |
Comments suppressed due to low confidence (2)
apps/idem-idp/k8s/chart/values.yaml:16
dns.appNameis defined in values.yaml but is not referenced by any template in this chart (the hostname is built fromdns.prefix+dns.domain). Either removedns.appName(and update docs accordingly) or incorporate it into the HTTPRoute hostname construction to avoid unused/misleading configuration.
apps/api/k8s/chart/values.yaml:45database.enabledis declared in values.yaml but is not used by any template in this chart. If it’s not implemented yet, consider removing it to avoid implying the chart manages database resources/config.
- Move chart/ to k8s/chart/ for api, idem-admin, and idem-idp - Add k8s/README.md deployment guides for each app - Update documentation references in argocd-setup.md - Preserve git history with mv/rename operations Benefits: - Clearer separation of k8s deployment from app code - Room for future k8s resources (kustomize, scripts, etc.) - Consistent structure across all applications - Improved documentation for deployment workflows
losolio
force-pushed
the
ci/k8s-updates
branch
from
71d8532 to
1a347e8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits: