fix too early unsubscription from channel pattern when there are mult…#41
Open
godness84 wants to merge 1 commit intolouischatriot:masterfrom
Open
fix too early unsubscription from channel pattern when there are mult…#41godness84 wants to merge 1 commit intolouischatriot:masterfrom
godness84 wants to merge 1 commit intolouischatriot:masterfrom
Conversation
…iple listeners on the same channel pattern.
Collaborator
|
Sorry for the long delay, the PR looks good but could you please add some tests to make sure that we can spot regressions? |
|
Any news for resolve this bug? I have same problem when subscribe multiple times same channel... When I call unsubscribe, all listeners are closed :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix too early unsubscription from channel pattern when there are multiple listeners on the same channel pattern.