Skip to content

Comments

Refactor part 1: Use ES6#44

Open
notVitaliy wants to merge 1 commit intolouischatriot:masterfrom
notVitaliy:master
Open

Refactor part 1: Use ES6#44
notVitaliy wants to merge 1 commit intolouischatriot:masterfrom
notVitaliy:master

Conversation

@notVitaliy
Copy link

No description provided.

@RangerMauve
Copy link
Collaborator

This is a pretty huge rewrite. Any particular reason that this needs to be done?

@notVitaliy
Copy link
Author

I'm planning a part 2 of this, to use async/await

This PR starts that process.

@RangerMauve
Copy link
Collaborator

I like the idea, but I'm worried about supporting older Node environments. What do you think about using babel transpilation to es5 so that the library can still be used on older version?

@notVitaliy
Copy link
Author

Yea, that'll work. It could be done as a pre-publish hook for npm.

@RangerMauve
Copy link
Collaborator

Would you mind setting that up before we merge it in? Also, would you be interested in becoming a collaborator?

@notVitaliy
Copy link
Author

Sure, I'll try to get to it in the next couple weeks.

Yea, why not. I've got some ideas for this lib.

  • an option for message reply
  • push/worker mode (message is only ever sent to 1 worker, worker needs to ack)

Pretty sure both of those can be done with bacon.js or RxJS.

@RangerMauve
Copy link
Collaborator

@louischatriot Would you mind giving @notVitaliy access as a collaborator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants