WIP: Add Background Tool, Pointer Tool, Minio Support#21
WIP: Add Background Tool, Pointer Tool, Minio Support#21654wak654 wants to merge 3 commits intolovasoa:masterfrom 654wak654:master
Conversation
| - Pointer (Shortcut: `f`): Allows users to point at things for others to see. | ||
|
|
||
| #### Minio suport: | ||
| - Instead of writing to the filesystem, the server now saves boards to a minio instance. The configuration is inside [server/minio.js](server/minio.js). |
There was a problem hiding this comment.
I don't think we want the changes to the README
There was a problem hiding this comment.
Yup, it's in my TODO list to just remove these.
| @@ -0,0 +1,2 @@ | |||
| # Default ignored files | |||
| /workspace.xml | |||
There was a problem hiding this comment.
Maybe we should add .idea and .vscode to the gitignore instead of checking them in.
| "shortcut": "b", | ||
| "draw": draw, | ||
| "onstart": onstart | ||
| }); |
There was a problem hiding this comment.
I'm not sure about that tool. It could quickly get out of hands with many users...
There was a problem hiding this comment.
Yes it's not something for public boards. Maybe it could be enabled when creating a board? Or even in the server?
| "onquit": () => showPointer(false, true), | ||
| "mouseCursor": "none", | ||
| "stylesheet": "tools/pointer/pointer.css" | ||
| }); |
There was a problem hiding this comment.
This tool seems very useful ! This is the one I think we need the most. But it should have one pointer per user.
| catchCallback(err, false); | ||
| } | ||
| accept(boardData); | ||
| }); |
There was a problem hiding this comment.
Maybe we could have a simple Persistence interface, that just asynchronously writes or read a value for a key, and have the backend (file or minio) chosen using an environment variable.
lovasoa
force-pushed
the
master
branch
2 times, most recently
from
d2ff89d to
189ebbe
Compare
2 participants
When merged this pull request will:
Add a background tool (Shortcut: b): Allows you to upload an image for the background of the canvas.
Add a pointer tool (Shortcut: f): Allows users to point at things for others to see.
Add support for minio object storage.
Other TODOs: