added selector tool to move objects#29
added selector tool to move objects#29Mk-arc wants to merge 1 commit intolovasoa:masterfrom Mk-arc:master
Conversation
|
Ohhh I just saw that someone else is working on this issue #10 |
|
Awesome, let's work on this together ! Just a question before I dive deeper into your code: why did you choose to create a new "modify" event type instead of reusing "update" ? |
I encountered this problem before, and the easiest solution is to throttle the updates. See how this is done in the pencil tool : If we need it in the selection tool too, then we may want to move the throttling code to board.js so that it can be reused by all tools. |
Fair question. I think theres no really specific reason. I guess it seemed more suitable for me to just "modify" the values that are actuallly considered by the change instead of overwriting the whole object. |
d2ff89d to
189ebbe
Compare
Hi there,
note: This is still work in progress. I just want to inform you as soon as possible that something is happening here.
I started implementing a "selector"-Tool to move objects after they have been placed. So far it works for Text, Lines and Rectangles... Pencil strokes are still up for implementation.
Problems that i noticed so far:
Also... this is the first time I worked with javascript... Im coming more from the embedded C++ world. So probably a lot of stuff I did is garbage. It would be nice to receive some help on this issue so we can finish this features fast. Its important :)