Open
Conversation
lovasoa
requested changes
Dec 13, 2024
Owner
lovasoa
left a comment
There was a problem hiding this comment.
This seems very specific, and not really useful outside of your case. Maybe this should be an external plugin instead, and what we should have in the code is something like WBO_EXTERNAL_TOOLS that you would set to a value like ["http://example.com/yourtool.js"] ?
Author
|
I didn't see a way to easily conditionally inject the tool js without resorting to a build process - If you've got a rough direction I can see if I can find time to whip it up. |
Author
|
Note that the exit button only shows up if the env var or config is set, invisible and missing by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#317
Adds an exit button with configuration to enable.
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.