feat: Add dark theme support with system preference detection#333
Open
pesnik wants to merge 1 commit intolovasoa:masterfrom
Open
feat: Add dark theme support with system preference detection#333pesnik wants to merge 1 commit intolovasoa:masterfrom
pesnik wants to merge 1 commit intolovasoa:masterfrom
Conversation
- Implements CSS custom properties for light/dark themes - Auto-detects system dark mode preference via prefers-color-scheme - Adds theme toggle button with persistent localStorage preference - Updates all SVG tool icons to use currentColor for compatibility - Adds toggle_theme translations for all 21 languages - Includes smooth CSS transitions (excludes canvas for performance) - Improves accessibility with ARIA attributes and focus indicators - Ensures WCAG AA color contrast compliance Closes lovasoa#219
Owner
|
I think the thing that is hard when implementing a dark theme for a whiteboard is to ensure the contrast and accessibility of the contents inside the whiteboard. Something drawn in black would become invisible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Implements CSS custom properties for light/dark themes
- Auto-detects system dark mode preference via prefers-color-scheme
- Adds theme toggle button with persistent localStorage preference
- Updates all SVG tool icons to use currentColor for compatibility
- Adds toggle_theme translations for all 21 languages
- Includes smooth CSS transitions (excludes canvas for performance)
- Improves accessibility with ARIA attributes and focus indicators
- Ensures WCAG AA color contrast compliance Closes Dark theme / dark reader support #219
By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.