[flash_ctrl,dv] Get flash_ctrl DV working better with Xcelium#28695
Merged
rswarbrick merged 2 commits intolowRISC:masterfrom Mar 9, 2026
Merged
[flash_ctrl,dv] Get flash_ctrl DV working better with Xcelium#28695rswarbrick merged 2 commits intolowRISC:masterfrom
rswarbrick merged 2 commits intolowRISC:masterfrom
Conversation
gautschimi
approved these changes
Nov 10, 2025
hw/ip_templates/flash_ctrl/dv/env/seq_lib/flash_ctrl_filesystem_support_vseq.sv
Show resolved
Hide resolved
rswarbrick
force-pushed
the
flash-ctrl-xcelium
branch
from
a67105d to
123382c
Compare
gautschimi
reviewed
Nov 10, 2025
hw/ip_templates/flash_ctrl/dv/env/seq_lib/flash_ctrl_filesystem_support_vseq.sv
Show resolved
Hide resolved
gautschimi
suggested changes
Nov 10, 2025
hw/ip_templates/flash_ctrl/dv/env/seq_lib/flash_ctrl_filesystem_support_vseq.sv
Outdated
Show resolved
Hide resolved
rswarbrick
force-pushed
the
flash-ctrl-xcelium
branch
from
123382c to
e48b858
Compare
vogelpi
approved these changes
Mar 6, 2026
Contributor
vogelpi
left a comment
vogelpi
left a comment
There was a problem hiding this comment.
Thanks @rswarbrick for you work on this and thanks @gautschimi for your review.
Contributor
|
@rswarbrick would you mind rebasing this and rerunning CI before merging please? I noticed that this PR is quite old. |
The previous version of the line causes *E,WOUPXR with Xcelium 24.03-s007 (the version I just tried). I'm not entirely sure why: the error message is described on the Cadence support site as complaining if you use a queue or array in a context that expects a boolean. This trivial workaround seems to sort things out. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
Because dv_base_test defaults to max_quit_count=1, the test would have died on the first mismatch before. It's pretty easy to just print the first few and to print the number of mismatches, so let's do that. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
flash-ctrl-xcelium
branch
from
e48b858 to
8eb40af
Compare
Contributor
Author
|
I've just rebased this. I dropped the final commit, because there's a nicer version of the same change in a separate PR (#29330). Let's land that through that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent some time looking at flash_ctrl DV when trying to figure out a problem with #28581. Since I'm much more competent with Simvision than Verdi, I spent a few minutes getting things to work with Xcelium. Fortunately it wasn't hard!