[dv] Fail more cleanly on a time-out when sending TL transaction#29314
Closed
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Closed
[dv] Fail more cleanly on a time-out when sending TL transaction#29314rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Conversation
The existing code (from d6eff63) was sort of ok and avoided timeouts if you sent lots of transactions. (Good!) Unfortunately, I hadn't noticed that you would end up dereferencing a null pointer if there was a genuine timeout. Fix that and fail with more informative error than "null pointer dereference". Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
added
Component:DV
Contributor
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
One inline question
Contributor
Author
|
... well that's embarrassing. A different commit (b735ae8) landed just over a week ago, which does almost exactly the same thing. What's worse, that commit was also written by me, and I only realised when rebasing this PR. I think Rupert needs to improve his memory... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code (from d6eff63) was sort of ok and avoided timeouts if you sent lots of transactions. (Good!) Unfortunately, I hadn't noticed that you would end up dereferencing a null pointer if there was a genuine timeout.
Fix that and fail with more informative error than "null pointer dereference".