[i2c,hw] Correct assign/compare widths#29426
Open
elliotb-lowrisc wants to merge 1 commit intolowRISC:masterfrom
Open
[i2c,hw] Correct assign/compare widths#29426elliotb-lowrisc wants to merge 1 commit intolowRISC:masterfrom
elliotb-lowrisc wants to merge 1 commit intolowRISC:masterfrom
Conversation
Fix assignment and comparison widths in the i2c controller and target FSM modules that do not match. Most were introduced by: lowRISC#22577 In the case where there are two narrower signals are being added, I have attempted to preserve what I believe is the the design intent by maintaining minimum-width adders and padding the result. Signed-off-by: Elliot Baptist <elliot.baptist@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix assignment and comparison widths in the i2c controller and target FSM modules that do not match.
Most were introduced by: #22577
In the case where there are two narrower signals are being added, I have attempted to preserve what I believe is the the design intent by maintaining minimum-width adders and padding the result.