Skip to content

[Fix]: charts theme #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Fix]: charts theme #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/packages/lowcoder-comps/src/comps/barChartComp/barChartComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ BarChartTmpComp = withViewFn(BarChartTmpComp, (comp) => {
log.error('theme chart error: ', error);
}


// Detect race mode changes and force chart recreation
const currentRaceMode = comp.children.chartConfig?.children?.comp?.children?.race?.getView();
useEffect(() => {
Expand Down Expand Up @@ -172,7 +173,6 @@ BarChartTmpComp = withViewFn(BarChartTmpComp, (comp) => {
useResizeDetector({
targetRef: containerRef,
onResize: ({width, height}) => {
console.log('barChart - resize');
if (width && height) {
setChartSize({ w: width, h: height });
}
Expand All @@ -194,6 +194,7 @@ BarChartTmpComp = withViewFn(BarChartTmpComp, (comp) => {
notMerge={!currentRaceMode}
lazyUpdate={!currentRaceMode}
opts={{ locale: getEchartsLocale() }}
theme={themeConfig}
option={option}
mode={mode}
/>
Expand Down
1 change: 1 addition & 0 deletions client/packages/lowcoder-comps/src/comps/lineChartComp/lineChartComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ LineChartTmpComp = withViewFn(LineChartTmpComp, (comp) => {
notMerge
lazyUpdate
opts={{ locale: getEchartsLocale() }}
theme={themeConfig}
option={option}
mode={mode}
/>
Expand Down
1 change: 1 addition & 0 deletions client/packages/lowcoder-comps/src/comps/pieChartComp/pieChartComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ PieChartTmpComp = withViewFn(PieChartTmpComp, (comp) => {
notMerge
lazyUpdate
opts={{ locale: getEchartsLocale() }}
theme={themeConfig}
option={option}
mode={mode}
/>
Expand Down
1 change: 1 addition & 0 deletions client/packages/lowcoder-comps/src/comps/scatterChartComp/scatterChartComp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ ScatterChartTmpComp = withViewFn(ScatterChartTmpComp, (comp) => {
notMerge
lazyUpdate
opts={{ locale: getEchartsLocale() }}
theme={themeConfig}
option={option}
mode={mode}
/>
Expand Down
Loading