Upgrade Node and Add eslint #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This will have some merge conflicts after the localization changes went in. Happy to review once they're sorted! |
halkeye
force-pushed
the
add-eslint
branch
3 times, most recently
from
2d52c9a to
d85548e
Compare
pnpm eslint src No current errors make sure ci is also running node 22
halkeye
force-pushed
the
add-eslint
branch
5 times, most recently
from
b849706 to
0d15653
Compare
Contributor
Author
|
I swear this was working fine before but updated now: Hopefully nothing else? |
halkeye
commented
May 29, 2025
| console.log("Language Change:", { | ||
| header: req.headers["accept-language"], | ||
| detected: req.language, | ||
| currentLanguage: currentLanguage, |
Contributor
Author
There was a problem hiding this comment.
eslint didn't like currentLanguage being defined and not used, so i just wrapped it in an env variable
plus bleh commented out code :)
raphaelkabo
approved these changes
Jul 3, 2025
Contributor
raphaelkabo
left a comment
raphaelkabo
left a comment
There was a problem hiding this comment.
Awesome work, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just deleting unused imports and variables
added some _ to some of the function parmaeters are not used
Upgrade node to 22
eslint fixed some var => const|let