Skip to content

Conversation

@reggi
Copy link
Contributor

@reggi reggi commented Oct 21, 2025

This pr adds linting and prettier formatting (which is already a dependency) to scripts and to ci and applies the fixes to fix the formatting. I'd encourage you to switch to tabs being 2 spaces rather than 4 but no biggie if this is the preference.

@lowercasename
Copy link
Owner

Ah, I see we're going for 'contributor with the most lines changed with this one weird trick', absolute respect for this 😉 . I would also prefer 2 spaces - will be happy to merge if you can update it to that.

@halkeye
Copy link
Contributor

halkeye commented Nov 11, 2025

@lowercasename I really would like to see this merged cause it would make it easier to submit bigger changes (I really want to convert
Then to await async). Do you want me to update this pr? Do you want to update the config and run auto fix so you don't risk changes from others?

@lowercasename
Copy link
Owner

Yeah, let's merge this in and then I/you can update the Prettier config in a separate PR, especially because there are some other things bubbling up in PR.

@halkeye
Copy link
Contributor

halkeye commented Nov 11, 2025

https://github.com/lowercasename/gathio/blob/main/.prettierrc.json#L2
then prettier -w

but yea, i'm up for more line count myself

@lowercasename
Copy link
Owner

Github actions appears to not be working so will re-run checks when it does and merge. :)

@halkeye
Copy link
Contributor

halkeye commented Nov 11, 2025

Github actions appears to not be working so will re-run checks when it does and merge. :)

it might not trigger when a pr modifies actions by someone without write access. That might be the excuse to update the config, run prettier and update the branch, so github actions knows its a safe branch

@halkeye
Copy link
Contributor

halkeye commented Nov 11, 2025

oh or try retry on https://github.com/lowercasename/gathio/actions/runs/18672657706
it may have been duing the outage.

@lowercasename lowercasename merged commit ec74e0a into lowercasename:main Nov 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants