Support env variables inside config variables #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
oh i see #219 is another way to do it. |
Contributor
Author
|
Okay, based on #219, i moved it to after toml parsing. I think its way more complicated this way |
site_name=$USER}'s event site will get pouplated by process.env.GATHIO_USER
halkeye
force-pushed
the
support-env-in-config
branch
from
671547a to
80749b1
Compare
Contributor
Author
|
@lowercasename rebased after prettier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so
site_name=$GATHIO_USER}'s event sitewill get pouplated by process.env.GATHIO_USER
For the docker container. I would like to inject credentials from outside. I like having my config file public in my devops repo, then any secrets are hidden.
There's other ways for me to do it if you don't want it.