Merged
Conversation
Owner
|
Thanks @karldw! One minor things: Could you be more precise on the warning message by telling when the KP stat is actually implemented? |
Contributor
Author
|
Thanks! Does this edit fit what you had in mind? I'm happy to make any changes. |
Owner
|
Sorry for the late reply. And sorry for yet other comments:
I'm also happy to make the changes when I get the chance in January. |
Owner
|
All good, thanks. Sorry for the back and forth. |
Contributor
Author
|
No problem at all -- thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #607
Error in solve(t(Gmat)) %*% PIby ensuringPIis a matrix rather than a dataframe (as mentioned in Kleibergen-Paap test code broken; Effective F-statistic implementation #161 (comment))NAvalue for that case.