Skip to content

Comments

Fixes for KP stat calculation#612

Merged
lrberge merged 3 commits intolrberge:masterfrom
karldw:fix-607
Nov 25, 2025
Merged

Fixes for KP stat calculation#612
lrberge merged 3 commits intolrberge:masterfrom
karldw:fix-607

Conversation

@karldw
Copy link
Contributor

@karldw karldw commented Oct 19, 2025

Fixes #607

@lrberge
Copy link
Owner

lrberge commented Oct 23, 2025

Thanks @karldw!

One minor things: Could you be more precise on the warning message by telling when the KP stat is actually implemented?

@karldw
Copy link
Contributor Author

karldw commented Nov 16, 2025

Thanks! Does this edit fit what you had in mind? I'm happy to make any changes.

@lrberge
Copy link
Owner

lrberge commented Nov 18, 2025

Sorry for the late reply. And sorry for yet other comments:

  • can you return(NA) directly right at the beginning of the function (circa line 1626)? And not wait for the case to pop later on (this avoids unnecessary calculations)?
  • can you drop the last line in the warning (this is implicit)?

I'm also happy to make the changes when I get the chance in January.

@lrberge lrberge merged commit 6d0fd73 into lrberge:master Nov 25, 2025
4 checks passed
@lrberge
Copy link
Owner

lrberge commented Nov 25, 2025

All good, thanks. Sorry for the back and forth.

@karldw
Copy link
Contributor Author

karldw commented Nov 26, 2025

No problem at all -- thanks for reviewing!

@karldw karldw deleted the fix-607 branch November 26, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error thrown in Kleibergen-Paap (kpr) calculation

2 participants