fix: add missing doc and symbol modules to lsap-sdk#40
Open
bushnelb wants to merge 1 commit intolsp-client:mainfrom
Open
fix: add missing doc and symbol modules to lsap-sdk#40bushnelb wants to merge 1 commit intolsp-client:mainfrom
bushnelb wants to merge 1 commit intolsp-client:mainfrom
Conversation
lsp-cli 0.3.3+ imports from lsap.capability.doc and lsap.schema.doc, but these modules were never included in the lsap-sdk 0.2.0 PyPI release. This causes ModuleNotFoundError on any lsp command. Cherry-picks the doc and symbol modules from the copilot/rename-hover-api-to-doc-api branch to make the published lsap-sdk compatible with published lsp-cli versions. Fixes lsp-client#39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fresh installs of
lsp-cli(0.3.3 or 0.4.0) viauv tool install lsp-cliare completely broken becauselsap-sdk==0.2.0on PyPI is missing thedocandsymbolmodules thatlsp-cliimports.Fix
Cherry-picks the
docandsymbolcapability and schema modules from thecopilot/rename-hover-api-to-doc-apibranch intomain, so the next PyPI release oflsap-sdkwill be compatible with the already-publishedlsp-cli.Files added:
src/lsap/capability/doc.py— Doc (hover) capabilitysrc/lsap/schema/doc.py— Doc request/response schemasrc/lsap/capability/symbol.py— Symbol capability (renamed from inspect)src/lsap/schema/symbol.py— Symbol request/response schemasrc/lsap/capability/__init__.pyexportsAdditional note
There's also a
LineScope.linevsstart_line/end_linemismatch inlsp-cli'sshared.py— I'll file that separately on thelsp-skillrepo since it's a CLI-side issue.Fixes #39