DM-53861: Add TMA truss temperature columns to lsstcam EFD#105
Merged
rcboufleur merged 2 commits intomainfrom Feb 3, 2026
Merged
DM-53861: Add TMA truss temperature columns to lsstcam EFD#105rcboufleur merged 2 commits intomainfrom
rcboufleur merged 2 commits intomainfrom
Conversation
Add truss_temp_plus_x_plus_y and truss_temp_minus_x_minus_y to exposure_efd and visit1_efd, sourced from lsst.sal.ESS.temperature. Bump schema version to 1.1.0. DM-53861
bbrondel
approved these changes
Jan 29, 2026
| tables: ["exposure_efd","visit1_efd"] | ||
| function: mean | ||
| datatype: float | ||
| ivoa: {"unit":"deg_C", "ucd":"meta.ucd;stat.mean"} |
Collaborator
There was a problem hiding this comment.
Suggested change
| ivoa: {"unit":"deg_C", "ucd":"meta.ucd;stat.mean"} | |
| ivoa: {"unit":"deg_C", "ucd":"phys.temperature;stat.mean"} |
This does not appear to be an appropriate use of the meta.ucd UCD. The column contains a temperature measurement, not a UCD label.
Contributor
Author
There was a problem hiding this comment.
I used meta.ucd as a placeholder because stat.mean requires primary label. I'll update the cases where unit is dec_C to the appropriate UCD label.
edennihy
requested changes
Jan 29, 2026
edennihy
left a comment
edennihy
left a comment
There was a problem hiding this comment.
Please hold off on merging for now, there is a new, open question about the name and description to use.
|
Okay, after some discussion we came to a new consensus for the column names and descriptions. Please see https://rubinobs.atlassian.net/browse/DM-53861?focusedCommentId=626339 for the new request. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add truss_temp_plus_x_plus_y and truss_temp_minus_x_minus_y to exposure_efd and visit1_efd, sourced from lsst.sal.ESS.temperature. Bump schema version to 1.1.0.