Closed
Conversation
Vebop
approved these changes
Nov 21, 2024
Collaborator
Vebop
left a comment
Vebop
left a comment
There was a problem hiding this comment.
I just had a few questions, but nothing to really fix. Love the added detail!
| See the :ref:`add-columns-structure` section below. | ||
|
|
||
| - Identify the source of the data. | ||
| ConsDB does not produce any data itself, nor does the ConsDB team request that sources produce data. |
Collaborator
There was a problem hiding this comment.
I'm trying to understand this second phrase, does that mean we don't go ask EFD to start producing an entry we want?
| - Provide information about the requested columns including a brief description in the appropriate Confluence page: `Transformed EFD <https://rubinobs.atlassian.net/wiki/x/Ii7pAg>`__ or `Non-EFD <https://rubinobs.atlassian.net/wiki/x/GICzDg>`__. | ||
| This provides an opportunity for discussion and comment on the suitability of the columns. | ||
|
|
||
| - For non-EFD columns, file a Jira ticket and start a corresponding pull request to modify the `sdm_schemas <https://github.com/lsst/sdm_schemas>`__ repository with appropriate entries for the desired columns. |
Collaborator
There was a problem hiding this comment.
Please add 'Link that ticket in the confluence page above'
| This data will go into a ``*_efd`` table. | ||
|
|
||
| - A system (e.g. the Camera Control System), service (e.g. Rapid Analysis), or campaign/pipeline (e.g. Nightly Validation) executing at the Summit or USDF. | ||
| This data will go into a table with a suffix specific to the source. |
Collaborator
There was a problem hiding this comment.
Just for my own clarification, RA -> _quicklook, so the suffix is specific, but doesn't have to match the service name. Are there any other suffix specific service/pipeline/system ones yet?
JeremyMcCormick
force-pushed
the
u/ktl/add-schema-checklist
branch
from
df24b1f to
b7d857e
Compare
Add specifics on Jira ticket usage and approval processes.
ktlim
force-pushed
the
u/ktl/add-schema-checklist
branch
from
b7d857e to
58ca4e4
Compare
Contributor
Author
|
Merging with DM-53298 (#99). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.