Open
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 92.76% 92.36% -0.41%
==========================================
Files 22 22
Lines 2918 2998 +80
Branches 305 306 +1
==========================================
+ Hits 2707 2769 +62
- Misses 132 156 +24
+ Partials 79 73 -6 ☔ View full report in Codecov by Sentry. |
1855d79 to
b1bf839
Compare
fef38e7 to
e40964f
Compare
a633477 to
7ad5b59
Compare
7ad5b59 to
b5671af
Compare
56c41c3 to
72a61ee
Compare
Replace the call map with a class for handling each type of change.
72a61ee to
3e0212d
Compare
3e0212d to
960d026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a major overhaul of the
diffmodule to fix issues/bugs in the comparison tools, add a few new features, and restructure the formatted diff output into JSON instead of unstructured text. The associated Jira ticket contains more complete information on what was done.The module was rewritten to be much simpler, leveraging the internal data structures of
deepdiffmore than previously to avoid excessive data manipulations and transformations.NOTE: The database diff tool, which is modified on this PR, mainly with improved error handling, is planned to be moved to another module entirely with its own, dedicated command (DM-51697). The structure of its implementation reflected in this PR will be heavily revised, based on that work.
Checklist
docs/changes