DM-53979: Fix issue with attribute copying from column ref overrides#174
Merged
JeremyMcCormick merged 2 commits intomainfrom Jan 29, 2026
Merged
DM-53979: Fix issue with attribute copying from column ref overrides#174JeremyMcCormick merged 2 commits intomainfrom
JeremyMcCormick merged 2 commits intomainfrom
Conversation
JeremyMcCormick
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 91.69% 91.58% -0.12%
==========================================
Files 13 13
Lines 2024 2031 +7
Branches 290 291 +1
==========================================
+ Hits 1856 1860 +4
- Misses 110 111 +1
- Partials 58 60 +2 ☔ View full report in Codecov by Sentry. |
JeremyMcCormick
force-pushed
the
tickets/DM-53979
branch
2 times, most recently
from
198d42e to
ca6a6d7
Compare
timj
reviewed
Jan 29, 2026
Member
timj
left a comment
timj
left a comment
There was a problem hiding this comment.
How do you know you fixed the bug if there is no test?
timj
approved these changes
Jan 29, 2026
Member
timj
left a comment
timj
left a comment
There was a problem hiding this comment.
Thanks for explaining that model_dump is the problem here. Please add some context to the commit message stating that the fundamental issue is that you have to avoid model_dump because it coerces types to JSON-safe form.
JeremyMcCormick
force-pushed
the
tickets/DM-53979
branch
2 times, most recently
from
c3c119a to
e6bbac1
Compare
Using `model_dump` was causing conversion to JSON types here, so the `datatype` attribute was being assigned a `str` object and not a `StrEnum`, which broke code attempting to use the field as an enum. Copying the attributes directly fixes this issue, as it preserves the Python types at runtime and avoids the conversion.
JeremyMcCormick
force-pushed
the
tickets/DM-53979
branch
from
e6bbac1 to
72dae45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
docs/changes