Skip to content

DM-53999: Improve handling and validation of column overrides#175

Merged
JeremyMcCormick merged 2 commits intomainfrom
tickets/DM-53999
Feb 2, 2026
Merged

DM-53999: Improve handling and validation of column overrides#175
JeremyMcCormick merged 2 commits intomainfrom
tickets/DM-53999

Conversation

@JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Jan 30, 2026

This PR improves the handling of column overrides:

  • Added an _update_from_overrides method on Column for updating attributes from a ColumnOverrides object
    • Used model_fields_set in this method so that explicitly setting some attributes to None is allowed (specifically, description and tap_column_index)
    • Added a validation method to make sure that overriding certain fields to None is disallowed
  • Set model_config on ColumnOverrides, copied from the default Felis config (needs to be done explicitly since ColumnOverrides does not inherit from Felis's base model class)
  • Added significantly better test coverage

Checklist

  • Ran Jenkins
  • Added a release note for user-visible changes to docs/changes

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.75%. Comparing base (5e449c1) to head (d32821d).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   91.58%   91.75%   +0.17%     
==========================================
  Files          13       13              
  Lines        2031     2038       +7     
  Branches      291      293       +2     
==========================================
+ Hits         1860     1870      +10     
+ Misses        111      110       -1     
+ Partials       60       58       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyMcCormick JeremyMcCormick marked this pull request as draft January 30, 2026 21:12
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-53999 branch 3 times, most recently from 184c911 to 96760f5 Compare January 30, 2026 21:20
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review January 30, 2026 21:23
@JeremyMcCormick JeremyMcCormick requested a review from timj January 30, 2026 21:23
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments that I think need addressing.

@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-53999 branch 2 times, most recently from 3f6676e to c1bff82 Compare February 2, 2026 22:01
@JeremyMcCormick JeremyMcCormick requested a review from timj February 2, 2026 22:08
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about logging

@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-53999 branch 3 times, most recently from edcaef6 to 2c4584b Compare February 2, 2026 23:01
@JeremyMcCormick JeremyMcCormick changed the title DM-53999: Add method to Column for updating its attributes from a set of overrides DM-53999: Improve handling and validation of column overrides Feb 2, 2026
@JeremyMcCormick JeremyMcCormick merged commit f0215ca into main Feb 2, 2026
25 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-53999 branch February 2, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants