DM-53999: Improve handling and validation of column overrides#175
Merged
JeremyMcCormick merged 2 commits intomainfrom Feb 2, 2026
Merged
DM-53999: Improve handling and validation of column overrides#175JeremyMcCormick merged 2 commits intomainfrom
JeremyMcCormick merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 91.58% 91.75% +0.17%
==========================================
Files 13 13
Lines 2031 2038 +7
Branches 291 293 +2
==========================================
+ Hits 1860 1870 +10
+ Misses 111 110 -1
+ Partials 60 58 -2 ☔ View full report in Codecov by Sentry. |
184c911 to
96760f5
Compare
96760f5 to
4d579bd
Compare
timj
requested changes
Jan 30, 2026
Member
timj
left a comment
There was a problem hiding this comment.
I have some comments that I think need addressing.
3f6676e to
c1bff82
Compare
edcaef6 to
2c4584b
Compare
2c4584b to
d32821d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of column overrides:
_update_from_overridesmethod onColumnfor updating attributes from aColumnOverridesobjectmodel_fields_setin this method so that explicitly setting some attributes toNoneis allowed (specifically,descriptionandtap_column_index)Noneis disallowedmodel_configonColumnOverrides, copied from the default Felis config (needs to be done explicitly sinceColumnOverridesdoes not inherit from Felis's base model class)Checklist
docs/changes