DM-53469: Modify brightStarStamps to allow for higher-order fit param… #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
approved these changes
Dec 4, 2025
Contributor
leeskelvin
left a comment
leeskelvin
left a comment
There was a problem hiding this comment.
Just a comment on renaming cross_tilt to curvature_xy, for consistency. Otherwise, this looks good to me, cheers!
bazkiaei
force-pushed
the
tickets/DM-53469
branch
from
1b720c1 to
29c6eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
brightStarStampsmodule to include the parameters required for non-linear fitting within the Bright Star Subtraction pipeline.