DM-53647: detectCoaddPeaks : Too high a fraction (1.0 > 0.9) of pixels were masked with current "bright" detection round thresholds. #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-53647
branch
3 times, most recently
from
a0b69e6 to
41c058a
Compare
kherner
approved these changes
Jan 27, 2026
| return bg | ||
|
|
||
| def _computeBrightDetectionMask(self, maskedImage, convolveResults): | ||
| def _computeBrightDetectionMask(self, maskedImage, convolveResults, maxBrightDetectionIter=15): |
Contributor
There was a problem hiding this comment.
Is it better to leave the default undefined here if it's getting pulled from the config? I'm just wondering if one can avoid having to set it in two places (here and line 127) if it ever changes in the future.
Contributor
Author
There was a problem hiding this comment.
Yeah, good point! Since it's essentially a private function anyway, I switched it so just use the config (in line with the other uses in this function), and I renamed the config to more closely follow the established conventions here (i.e. moved Max to the end of the name). I also reduced the default to 10 (which is still likely overkill, but this should be a total edge case situation, so shouldn't cost us much).
This guards against potentially very long (or infinite) running loops. Also adds a unittest check that forces entry into this loop to make sure it iterates just two times, having set the full images as having the DETECTION mask set, and checking that it fails at trying to lay down sky sources.
laurenam
force-pushed
the
tickets/DM-53647
branch
from
41c058a to
67c24f6
Compare
kherner
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.