DM-53919: Declutter logs in calibrateImage #1235
Conversation
kfindeisen
left a comment
kfindeisen
left a comment
There was a problem hiding this comment.
I'm a bit worried that this may be swinging too far in the opposite direction and not warning about things that are important, but I'm not actually qualified to tell.
| self.log.warning("n_above_max_per_amp = %d (abs max is %d)", n_above_max_per_amp, int(0.75*n_amp)) | ||
| self.log.debug("Making small tweak to threshold (from %.2f to %.2f)", | ||
| currentThresh, starBackgroundDetectionConfig.thresholdValue) | ||
| self.log.debug("n_above_max_per_amp = %d (abs max is %d)", n_above_max_per_amp, int(0.75*n_amp)) |
There was a problem hiding this comment.
Should this still warn when the absolute max is exceeded? I see there's a warning on maxDetFracForFinalBg, I can't tell whether this is related.
There was a problem hiding this comment.
Yeah, this "maximum" is not an absolute criterion in the usual sense. It is a deciding factor for the "making a small tweak" branch, so I added this info into that debug message (I'm not sure a user -- other than myself -- would really be able to glean much meaning out of it as an info after the fact, and hopefully the maxDetFracForFinalBg warning will do the talking.)
laurenam
force-pushed
the
tickets/DM-53919
branch
2 times, most recently
from
631f2ba to
982a25b
Compare
Having been significantly battle-tested, these logs can now be moved from warning to debug level.
laurenam
force-pushed
the
tickets/DM-53919
branch
from
982a25b to
7976612
Compare
No description provided.