Skip to content

fix iPhoneX lt_setBackgroundColor OverlayHeight BUG; #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeasonL wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix iPhoneX lt_setBackgroundColor OverlayHeight BUG; #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd2be1d
fix iPhoneX lt_setBackgroundColor OverlayHeight BUG;
JeasonL Sep 15, 2017
669fabc
fix iOS12 lt_setBackgroundColor bug
JeasonL Sep 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions LTNavigationBar/UINavigationBar+Awesome.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,31 @@
@implementation UINavigationBar (Awesome)
static char overlayKey;

- (UIView *)overlay
- (UIImage *)overlay
{
return objc_getAssociatedObject(self, &overlayKey);
}

- (void)setOverlay:(UIView *)overlay
- (void)setOverlay:(UIImage *)overlay
{
objc_setAssociatedObject(self, &overlayKey, overlay, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
}

- (void)lt_setBackgroundColor:(UIColor *)backgroundColor
{
if (!self.overlay) {
[self setBackgroundImage:[UIImage new] forBarMetrics:UIBarMetricsDefault];
self.overlay = [[UIView alloc] initWithFrame:CGRectMake(0, 0, CGRectGetWidth(self.bounds), CGRectGetHeight(self.bounds) + 20)];
self.overlay.userInteractionEnabled = NO;
self.overlay.autoresizingMask = UIViewAutoresizingFlexibleWidth; // Should not set `UIViewAutoresizingFlexibleHeight`
[[self.subviews firstObject] insertSubview:self.overlay atIndex:0];
self.overlay = ({
CGRect rect = CGRectMake(0.0, 0.0, 1.0, 1.0);
UIGraphicsBeginImageContext(rect.size);
CGContextRef context = UIGraphicsGetCurrentContext();
CGContextSetFillColorWithColor(context, backgroundColor.CGColor);
CGContextFillRect(context, rect);
UIImage *image = UIGraphicsGetImageFromCurrentImageContext();
UIGraphicsEndImageContext();
image;
});
}
self.overlay.backgroundColor = backgroundColor;
[self setBackgroundImage:self.overlay forBarMetrics:UIBarMetricsDefault];
}

- (void)lt_setTranslationY:(CGFloat)translationY
Expand All @@ -53,7 +58,7 @@ - (void)lt_setElementsAlpha:(CGFloat)alpha

UIView *titleView = [self valueForKey:@"_titleView"];
titleView.alpha = alpha;
// when viewController first load, the titleView maybe nil
// when viewController first load, the titleView maybe nil
[[self subviews] enumerateObjectsUsingBlock:^(UIView *obj, NSUInteger idx, BOOL *stop) {
if ([obj isKindOfClass:NSClassFromString(@"UINavigationItemView")]) {
obj.alpha = alpha;
Expand All @@ -67,7 +72,6 @@ - (void)lt_setElementsAlpha:(CGFloat)alpha
- (void)lt_reset
{
[self setBackgroundImage:nil forBarMetrics:UIBarMetricsDefault];
[self.overlay removeFromSuperview];
self.overlay = nil;
}

Expand Down