-
Notifications
You must be signed in to change notification settings - Fork 0
Update #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: globus
Are you sure you want to change the base?
Update #39
Changes from all commits
8035f6d
1201b3a
d9e0bf3
f93ee36
f088efa
a896955
d019a11
f2f9d05
d09f76c
e69cf6f
5d753d1
c047d4b
92d502d
8abf0a6
4697002
237243a
f677806
1507805
12a079d
182fef3
48f5064
c9acc2e
63eb80d
9a5748d
c856b07
a4ea861
7cd1b41
579fe0c
b88fcc4
39b1de1
9f5c713
1168c01
a61ec40
07a9647
d27d4c7
9d00ef3
1c1eb30
f71a080
ae7fa2e
9a24b32
b3e1c78
b68a121
c6e47b0
9f837dc
948b149
bce5d50
fb0e559
12b62c4
2ce4dc5
f8b753f
021144c
5a43070
8a95d1e
38c7003
6651d86
b336267
af7827e
80a76cb
db14dc1
a00c5c4
5c4f004
317186f
20aaf5a
83d36a8
fe537ee
00a45f5
eb1ee7e
a235fc9
2159884
febdf1a
88b3f0b
01c5681
fdcdba2
8b851c8
e37fbce
3f9ada4
fc1ad89
95a53d4
63a7753
c65a20f
7abb5fa
b4313ae
48bad38
9fa287d
c28ccf7
f81b78b
5d15183
f6bfb07
7cbd4ba
0a2f77e
7aa966d
a111fa5
072cd57
a3ce057
345a0af
8e18f64
18b26db
093a5f1
3fd78a9
8d93b1a
1a74ac5
2f4a303
b446904
79041e1
db44555
4947496
acff848
503b20e
12ef731
5d6e00a
e199bf1
edfdac2
a247df0
83e32fc
c8f93ff
aa6ba8c
90d7d59
bbc9bd4
8950015
fb61d37
1fcad70
c22e027
72d5de9
1928563
7cd30c4
4c9ab38
15ee5b1
2b1857a
cc91be8
8bf0dd0
0b9c412
fb80157
cfb6185
d4fbb63
761da9c
04ad1a6
4c40b05
688e451
ac3c5fc
052f886
7d341d7
d9d70fd
a224648
3013bb3
391c37c
9f6b77c
9634fc9
cb2df1a
3f101d3
1c5334f
88cff95
3433877
42e70aa
bdeadab
fc38858
7aa7735
2147e10
a5e1a08
b57d8a4
d99324d
974cd1a
2b8d600
57f3d99
e4b921e
ee3af4a
974fde1
b7c31ac
9a5b3d0
183ce1c
af54086
56b2207
5fda593
2c062bd
daa4e3f
21ab283
e76a366
e1ec2f8
d8f2add
99514ab
e83ceb8
ddd29ab
3f4cc64
4b98088
18e78c7
d3126f0
f0ae22d
684e0ba
5618740
168aa90
eee66d5
353ca92
03c3a8a
dd3a695
ee3f605
3966a3c
e6f4221
db953d0
f1dea35
c38aeac
8592e63
e1b4551
877e428
c4206f0
ba839a1
7be6af8
111e091
87df34f
449c2f7
ed65852
adf0e9f
5cca889
92d1ec8
e45d287
799a8d7
ab2c661
db2d192
1ab994e
8601113
543bc7c
e588be5
cc6bd1c
5e55658
de2b48f
30d369d
b1ef66b
c021fcf
6275ea9
dfc34ce
0689560
b785fb7
0f67286
b9d9c35
a96985e
2fe453c
fe63602
6a2e094
d3d3092
191e67e
c549bf5
ed624a5
df396e3
ec3c274
77a0552
f071dd7
338dfa2
fde9065
9958751
2e65650
ffa4619
f223fb2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| APP_IMAGE=gdcc/dataverse:unstable | ||
| POSTGRES_VERSION=17 | ||
| DATAVERSE_DB_USER=dataverse | ||
| SOLR_VERSION=9.8.0 | ||
| SKIP_DEPLOY=0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # https://www.git-scm.com/docs/gitattributes | ||
|
|
||
| # This set mandatory LF line endings for .sh files preventing from windows users to having to change the value of their git config --global core.autocrlf to 'false' or 'input' | ||
| *.sh text eol=lf |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
|
|
||
| # Any container related stuff should be assigned to / reviewed by Oliver and/or Phil | ||
| modules/container-configbaker/** @poikilotherm @pdurbin | ||
| modules/container-base/** @poikilotherm @pdurbin | ||
| src/main/docker/** @poikilotherm @pdurbin | ||
| docker-compose-dev.yml @poikilotherm @pdurbin | ||
| .github/workflows/scripts/containers** @poikilotherm @pdurbin | ||
| .github/workflows/container_* @poikilotherm @pdurbin |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Did you encounter something unexpected or incorrect in the Dataverse software? | ||
| We'd like to hear about it! | ||
| title: '' | ||
| labels: 'Type: Bug' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Thank you for contributing to the Dataverse Project through the creation of a bug report! | ||
|
|
||
| WARNING: If this is a security issue it should be reported privately to security@dataverse.org | ||
|
|
||
| More information on bug issues and contributions can be found in the "Contributing to Dataverse" page: | ||
| https://guides.dataverse.org/en/latest/contributor/index.html | ||
|
|
||
| Please fill out as much of the template as you can. | ||
| Start below this comment section. | ||
| --> | ||
| **What steps does it take to reproduce the issue?** | ||
|
|
||
| * When does this issue occur? | ||
|
|
||
|
|
||
| * Which page(s) does it occurs on? | ||
|
|
||
|
|
||
| * What happens? | ||
|
|
||
|
|
||
| * To whom does it occur (all users, curators, superusers)? | ||
|
|
||
|
|
||
| * What did you expect to happen? | ||
|
|
||
|
|
||
|
|
||
| **Which version of Dataverse are you using?** | ||
|
|
||
|
|
||
|
|
||
| **Any related open or closed issues to this bug report?** | ||
|
|
||
|
|
||
| **Screenshots:** | ||
|
|
||
| No matter the issue, screenshots are always welcome. | ||
|
|
||
| To add a screenshot, please use one of the following formats and/or methods described here: | ||
|
|
||
| * https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests | ||
| * | ||
|
|
||
|
|
||
| **Are you thinking about creating a pull request for this issue?** | ||
| Help is always welcome, is this bug something you or your organization plan to fix? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea or new feature for the Dataverse software! | ||
| title: 'Feature Request:' | ||
| labels: 'Type: Feature' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Thank you for contributing to the Dataverse Project through the creation of a feature request! | ||
|
|
||
| More information on ideas/feature requests and contributions can be found in the "Contributing to Dataverse" page: | ||
| https://guides.dataverse.org/en/latest/contributor/index.html | ||
|
|
||
| Please fill out as much of the template as you can. | ||
| Start below this comment section. | ||
| --> | ||
|
|
||
| **Overview of the Feature Request** | ||
|
|
||
|
|
||
| **What kind of user is the feature intended for?** | ||
| (Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin) | ||
|
|
||
|
|
||
| **What inspired the request?** | ||
|
|
||
|
|
||
| **What existing behavior do you want changed?** | ||
|
|
||
|
|
||
| **Any brand new behavior do you want to add to Dataverse?** | ||
|
|
||
|
|
||
| **Any open or closed issues related to this feature request?** | ||
|
|
||
| **Are you thinking about creating a pull request for this feature?** | ||
| Help is always welcome, is this feature something you or your organization plan to implement? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| name: Idea proposal | ||
| about: Propose a new idea for discussion to improve the Dataverse software! | ||
| title: 'Suggestion:' | ||
| labels: 'Type: Suggestion' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Thank you for contributing to the Dataverse Project through the creation of a feature request! | ||
|
|
||
| More information on ideas/feature requests and contributions can be found in the "Contributing to Dataverse" page: | ||
| https://guides.dataverse.org/en/latest/contributor/index.html | ||
|
|
||
| Please fill out as much of the template as you can. | ||
| Start below this comment section. | ||
| --> | ||
|
|
||
| **Overview of the Suggestion** | ||
|
|
||
|
|
||
| **What kind of user is the suggestion intended for?** | ||
| (Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin) | ||
|
|
||
|
|
||
| **What inspired this idea?** | ||
|
|
||
|
|
||
| **What existing behavior do you want changed?** | ||
|
|
||
|
|
||
| **Any brand new behavior do you want to add to Dataverse?** | ||
|
|
||
|
|
||
| **Any open or closed issues related to this suggestion?** | ||
|
|
||
|
|
||
| **Are you thinking about creating a pull request for this issue?** | ||
| Help is always welcome, is this idea something you or your organization plan to implement? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| **What this PR does / why we need it**: | ||
|
|
||
| **Which issue(s) this PR closes**: | ||
|
|
||
| - Closes # | ||
|
|
||
| **Special notes for your reviewer**: | ||
|
|
||
| **Suggestions on how to test this**: | ||
|
|
||
| **Does this PR introduce a user interface change? If mockups are available, please link/include them here**: | ||
|
|
||
| **Is there a release notes update needed for this change?**: | ||
|
|
||
| **Additional documentation**: |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Security | ||
|
|
||
| To report a security vulnerability please email security@dataverse.org as explained at https://guides.dataverse.org/en/latest/installation/config.html#reporting-security-issues | ||
|
|
||
| Advice on securing your installation can be found at https://guides.dataverse.org/en/latest/installation/config.html#securing-your-installation | ||
|
|
||
| Security practices and procedures used by the Dataverse team are described at https://guides.dataverse.org/en/latest/developers/security.html |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| name: "Setup Maven and Caches" | ||
| description: "Determine Java version and setup Maven, including necessary caches." | ||
| inputs: | ||
| git-reference: | ||
| description: 'The git reference (branch/tag) to check out' | ||
| required: false | ||
| default: '${{ github.ref }}' | ||
| pom-paths: | ||
| description: "List of paths to Maven POM(s) for cache dependency setup" | ||
| required: false | ||
| default: 'pom.xml' | ||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ inputs.git-reference }} | ||
| - name: Determine Java version by reading the Maven property | ||
| shell: bash | ||
| run: | | ||
| echo "JAVA_VERSION=$(grep '<target.java.version>' ${GITHUB_WORKSPACE}/modules/dataverse-parent/pom.xml | cut -f2 -d'>' | cut -f1 -d'<')" | tee -a ${GITHUB_ENV} | ||
| - name: Set up JDK ${{ env.JAVA_VERSION }} | ||
| id: setup-java | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: ${{ env.JAVA_VERSION }} | ||
| distribution: 'temurin' | ||
| cache: 'maven' | ||
| cache-dependency-path: ${{ inputs.pom-paths }} | ||
| - name: Download common cache on branch cache miss | ||
| if: ${{ steps.setup-java.outputs.cache-hit != 'true' }} | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| key: dataverse-maven-cache | ||
| path: ~/.m2/repository |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Set update schedule for GitHub Actions | ||
| # https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot | ||
|
|
||
| version: 2 | ||
| updates: | ||
|
|
||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| # Check for updates to GitHub Actions daily | ||
| interval: "daily" |
| Original file line number | Diff line number | Diff line change | |||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,32 @@ | |||||||||||||||||
| name: "Properties Check" | |||||||||||||||||
| on: | |||||||||||||||||
| pull_request: | |||||||||||||||||
| paths: | |||||||||||||||||
| - "src/**/*.properties" | |||||||||||||||||
| - "scripts/api/data/metadatablocks/*" | |||||||||||||||||
| jobs: | |||||||||||||||||
| duplicate_keys: | |||||||||||||||||
| name: Duplicate Keys | |||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||
| steps: | |||||||||||||||||
| - uses: actions/checkout@v4 | |||||||||||||||||
| - name: Run duplicates detection script | |||||||||||||||||
| shell: bash | |||||||||||||||||
| run: tests/check_duplicate_properties.sh | |||||||||||||||||
|
|
|||||||||||||||||
| metadata_blocks_properties: | |||||||||||||||||
| name: Metadata Blocks Properties | |||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||
| steps: | |||||||||||||||||
| - uses: actions/checkout@v4 | |||||||||||||||||
| - name: Setup GraalVM + Native Image | |||||||||||||||||
| uses: graalvm/setup-graalvm@v1 | |||||||||||||||||
| with: | |||||||||||||||||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||||||||||||||||
| java-version: '21' | |||||||||||||||||
| distribution: 'graalvm-community' | |||||||||||||||||
| - name: Setup JBang | |||||||||||||||||
| uses: jbangdev/setup-jbang@main | |||||||||||||||||
| - name: Run metadata block properties verification script | |||||||||||||||||
| shell: bash | |||||||||||||||||
| run: tests/verify_mdb_properties.sh | |||||||||||||||||
|
Comment on lines
+18
to
+32
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Copilot AutofixAI 10 months ago To fix the issue, we will add a
Suggested changeset
1
.github/workflows/check_property_files.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Refresh and try again.
|
|||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| # For most projects, this workflow file will not need changing; you simply need | ||
| # to commit it to your repository. | ||
| # | ||
| # You may wish to alter this file to override the set of languages analyzed, | ||
| # or to provide custom queries or build logic. | ||
| # | ||
| # ******** NOTE ******** | ||
| # We have attempted to detect the languages in your repository. Please check | ||
| # the `language` matrix defined below to confirm you have the correct set of | ||
| # supported CodeQL languages. | ||
| # | ||
| name: "CodeQL Advanced" | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "develop", "master" ] | ||
| pull_request: | ||
| branches: [ "develop", "master" ] | ||
| schedule: | ||
| - cron: '30 6 * * 4' | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: Analyze (${{ matrix.language }}) | ||
| # Runner size impacts CodeQL analysis time. To learn more, please see: | ||
| # - https://gh.io/recommended-hardware-resources-for-running-codeql | ||
| # - https://gh.io/supported-runners-and-hardware-resources | ||
| # - https://gh.io/using-larger-runners (GitHub.com only) | ||
| # Consider using larger runners or machines with greater resources for possible analysis time improvements. | ||
| runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} | ||
| permissions: | ||
| # required for all workflows | ||
| security-events: write | ||
|
|
||
| # required to fetch internal or private CodeQL packs | ||
| packages: read | ||
|
|
||
| # only required for workflows in private repositories | ||
| actions: read | ||
| contents: read | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - language: actions | ||
| build-mode: none | ||
| - language: java-kotlin | ||
| build-mode: none # This mode only analyzes Java. Set this to 'autobuild' or 'manual' to analyze Kotlin too. | ||
| - language: javascript-typescript | ||
| build-mode: none | ||
| - language: python | ||
| build-mode: none | ||
| # CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift' | ||
| # Use `c-cpp` to analyze code written in C, C++ or both | ||
| # Use 'java-kotlin' to analyze code written in Java, Kotlin or both | ||
| # Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both | ||
| # To learn more about changing the languages that are analyzed or customizing the build mode for your analysis, | ||
| # see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning. | ||
| # If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how | ||
| # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| # Add any setup steps before running the `github/codeql-action/init` action. | ||
| # This includes steps like installing compilers or runtimes (`actions/setup-node` | ||
| # or others). This is typically only required for manual builds. | ||
| # - name: Setup runtime (example) | ||
| # uses: actions/setup-example@v1 | ||
|
|
||
| # Initializes the CodeQL tools for scanning. | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| build-mode: ${{ matrix.build-mode }} | ||
| # If you wish to specify custom queries, you can do so here or in a config file. | ||
| # By default, queries listed here will override any specified in a config file. | ||
| # Prefix the list here with "+" to use these queries and those in the config file. | ||
|
|
||
| # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs | ||
| # queries: security-extended,security-and-quality | ||
|
|
||
| # If the analyze step fails for one of the languages you are analyzing with | ||
| # "We were unable to automatically build your code", modify the matrix above | ||
| # to set the build mode to "manual" for that language. Then modify this step | ||
| # to build your code. | ||
| # ℹ️ Command-line programs to run using the OS shell. | ||
| # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun | ||
| - if: matrix.build-mode == 'manual' | ||
| shell: bash | ||
| run: | | ||
| echo 'If you are using a "manual" build mode for one or more of the' \ | ||
| 'languages you are analyzing, replace this with the commands to build' \ | ||
| 'your code, for example:' | ||
| echo ' make bootstrap' | ||
| echo ' make release' | ||
| exit 1 | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v3 | ||
| with: | ||
| category: "/language:${{matrix.language}}" |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 10 months ago
To fix the issue, we will add a
permissionsblock at the root of the workflow file. This block will define the minimal permissions required for the workflow. Based on the tasks performed in the workflow, thecontents: readpermission is sufficient, as the workflow only checks out the repository and runs scripts without modifying any repository content.