Support building for AppleSilicon#33
Open
LucasAschenbach wants to merge 2 commits intoluchr:masterfrom
Open
Conversation
|
Bump |
|
Could this be a compatibility issue with the recently released Julia 1.10? |
|
Bump |
|
I also kicked off a Yggdrasil JLL build JuliaPackaging/Yggdrasil#11732 |
|
JuliaRegistries/General#135541 should largely workaround this. |
|
Locally, AppleSilicon works by default with the binaries from Yggdrasil now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
apple_silicon_flagto the build function inbuild.jlto automatically opt into building locally when called on AppleSilicon hardware. Similarly, theloadODESolvers()function now looks for local binaries instead of using ODEInterface_jll.jl when run on AppleSilicon.One other change I made was to add
loadODESolvers()to the__init__()call so the function does not need to be manually invoked for every new session. However, I'm not sure if that is the right place for calling the function.All tests in
runtests.jlpassed.