Fix "Absent Code attribute in method" errors #104
+36
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, during mixed compilation (compiling Scala and Java sources in the same target), instead of analyzing the compiled Java classes, we analyzed all classes in the output directory. Because we compile the Scala sources first, this meant Scala classes were being re-analyzed. I'm not sure why some Scala classes were missing code attributes, but the errors should be fixed (and compilation should be faster) by not re-analyzing them to begin with.
jjudd
approved these changes
Jan 27, 2026
jjudd
left a comment
jjudd
left a comment
There was a problem hiding this comment.
Approved with a few nits and one recommended change.
| val classes = DirectoryClassFinder(classesOutputDirectory).classes | ||
| val result = classes.paths.toSet | ||
|
|
||
| classes.close() |
There was a problem hiding this comment.
Does anything bad happen if this close isn't called? If so, should this use automatic resource management, so close is called automatically?
There was a problem hiding this comment.
Reading the original code in package.scala it looks like we will want to call close.
Can we utilize Using here to just call close automagically?
| val javaSources = normalizedSources.view.map(_.toString).filter(_.endsWith(".java")).toList | ||
|
|
||
| if (javaSources.nonEmpty) { | ||
| val classesBefore = findClassesInOutputDirectory() |
There was a problem hiding this comment.
Nit: before and after what? I believe it's Java compilation, but being a bit more specific here may help.
| val classFinder = new DirectoryClassFinder(outputDirectory) | ||
| val classes = classFinder.classes | ||
|
|
||
| try { |
There was a problem hiding this comment.
Looks like this try was only for the resource management, but I figured I'd ask to make sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, during mixed compilation (compiling Scala and Java sources in the same target), instead of analyzing the compiled Java classes, we analyzed all classes in the output directory. Because we compile the Scala sources first, this meant Scala classes were being re-analyzed.
I'm not sure why some Scala classes were missing code attributes, but the errors should be fixed (and compilation should be faster) by not re-analyzing them to begin with.