this seemed to fix my problems #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for investigating and providing a patch. What was the issue you were seeing, or were there multiple present? |
Author
|
there were a few. you were using the in-place option for sed, but didn't specify the actual file to edit. also, running ghc-pkg in place doesn't work because it's just a shell script that calls a hardcode path. |
Owner
|
OK thanks. I've got some work in progress code locally that I'll merge it with. |
Conflicts: bin/compile
Conflicts: bin/compile bin/release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: removed the "no" response, explicitly exited with 0 when detected, and switched to explicit #!/bin/bash. Not sure which one actually made a difference, but this is more closely modelled on the heroku docs.