Fix bug in bun manifest path#2018
Merged
jwoertink merged 3 commits intoluckyframework:mainfrom Feb 25, 2026
Merged
Conversation
This caused issues today where the bun tests failed because of the bun binary. This fix ensures we're getting the correct binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bug fix in bun manifest path.
Description
After deploying to production I noticed a bug in the path for Bun's
writeManifestmethod. It was caused by a relatively recent change and I didn't notice because the asset manifest was already in my codebase. I only noticed it because production wouldn't build. I've also added tests to ensure this won't happen again.Two other small changes are the
--remove-orphansflag in the test script, and installing bun in the Dockerfile for test s rather than pulling it in because the binary is not always the right one for the target.Checklist
crystal tool format spec src./script/setup./script/test