Option to pass vectors directly as second file#1
Open
mokenyi wants to merge 2 commits intolucydot:masterfrom
Open
Option to pass vectors directly as second file#1mokenyi wants to merge 2 commits intolucydot:masterfrom
mokenyi wants to merge 2 commits intolucydot:masterfrom
Conversation
…der instead of final positions.
lucydot
requested changes
Jun 13, 2019
Owner
lucydot
left a comment
lucydot
left a comment
There was a problem hiding this comment.
Hi @mokenyi thanks for the PR 😄 - could you include sample input files in the data folder? (feel free to add new sub-directories example_one / example_two - the README.md short tutorial will also need updating in this case but I can do that if you are short on time)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to allow second file to be interpreted as vectors to render instead of final positions.