Skip to content

fixed errors in earth911 mock APIs#242

Open
rohit-yadavv wants to merge 1 commit intolugenx:mainfrom
rohit-yadavv:fix/errors-in-earth911-mock-APIs
Open

fixed errors in earth911 mock APIs#242
rohit-yadavv wants to merge 1 commit intolugenx:mainfrom
rohit-yadavv:fix/errors-in-earth911-mock-APIs

Conversation

@rohit-yadavv
Copy link

@rohit-yadavv rohit-yadavv commented Sep 2, 2023

fixes #224
I have fixed errors in earth911 mock APIs
updated res.send({ err: "invalid key" })to return res.send({ err: "invalid key" });

image

@lugenx
Copy link
Owner

lugenx commented Sep 6, 2023

thank you @rohit-yadavv, this issue is being reviewed. in the future, kindly ensure you first create an issue (if one doesn't already exist) before making changes. after creating the issue, please comment on it asking for assignment. this ensures your efforts align with the project's direction and prevents any potential wasted effort.

@vishwaszadte
Copy link
Collaborator

Thank you @rohit-yadavv
Please feel free to look at any other endpoints which may have the same issue and let us know.

@lugenx
Copy link
Owner

lugenx commented Oct 23, 2023

@vishwaszadte Since we haven't received a response, could you please review and either approve or reject it? Thank you.

@Syed-Bilal-Haider-Engineer

@rohit-yadavv I want to involve your community in contributing to bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "[ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client" errors in earth911 mock APIs

4 participants