Skip to content

Code refactoring and enhancement#5

Open
Openuser87 wants to merge 9 commits intolugenx:mainfrom
Openuser87:pullreq
Open

Code refactoring and enhancement#5
Openuser87 wants to merge 9 commits intolugenx:mainfrom
Openuser87:pullreq

Conversation

@Openuser87
Copy link

Hello @lugenx !

Thank you for your script, it is helping me a lot in Keep -> Logseq migration!

As I needed some adjustments for my purpose, I also tried to split the code into separate functions and enhance it by some new features. Main changes are:

(1) Split the two original functions into separate functions, rewrite the code
(2) Allow for command line arguments (source and destination directory)
(3) Use readline-sync instead of readline
(4) Create separate Logseq pages instead of Journal pages
(5) Use page tags and timestamps
(6) Some bullet point cleanup (just for my particular purpose)
(7) Rename page files with slashes in the title (replace with ___)

If you would be interested, we could cooperate to make the script more useful for the folks out there. E.g. we could offer both options - journals and pages, with a possibility to select between them.

Let me know what you think, and if you would like the code committed back to your repo.

Regards!

PS. I am not a professional developer, and this is actually my first pull request on Github, so please correct me if I'm doing something wrong.

Openuser87 and others added 9 commits September 10, 2023 18:35
Fork info
…he code

(2) Allow for command line arguments (source and destination directory)
(3) use readline-sync instead of readline
(4) Create separate Logseq pages instead of Journal pages
(5) Use page tags and timestamps
(6) Some bulletpoint cleanup (author's individual need)
(7) Rename page files with slashes in the title
…he code

(2) Allow for command line arguments (source and destination directory)
(3) use readline-sync instead of readline
(4) Create separate Logseq pages instead of Journal pages
(5) Use page tags and timestamps
(6) Some bulletpoint cleanup (author's individual need)
(7) Rename page files with slashes in the title
Removing a change unneeded for pull req
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants