Skip to content

[azurekv] Support whole file encrption#63

Open
lukasjarosch wants to merge 3 commits intomainfrom
feat/azure-encrypt-file-test
Open

[azurekv] Support whole file encrption#63
lukasjarosch wants to merge 3 commits intomainfrom
feat/azure-encrypt-file-test

Conversation

@lukasjarosch
Copy link
Copy Markdown
Owner

Signed-off-by: Lukas Jarosch lukas.jarosch@mail.com

Comment thread internal/secret/azure.go
// We know this is an RSA Key so...
rsaKey, ok := rawkey.(*rsa.PublicKey)
if !ok {
panic(fmt.Sprintf("expected ras key, got %T", rawkey))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, an why not returning the error?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because its a poc 😄

Comment thread internal/secret/azure.go
panic(fmt.Sprintf("expected ras key, got %T", rawkey))
}
// As this is a demo just dump the key to the console
fmt.Println(rsaKey)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed before the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants