Conversation
| release: | ||
| types: [published] | ||
|
|
||
| env: |
There was a problem hiding this comment.
We can change this to environment variables defined in GitHub entirely? This way I can also publish images for my own use.
There was a problem hiding this comment.
I am all for this @DanielHabenicht. However, is there a way we can define multiple registries? I'd like to be able to publish this to ghcr.io as well as docker hub.
There was a problem hiding this comment.
yeah, I think I can add a condition for the publish to docker so its only executed on this repository
| ImageData imageData = ImageDataFactory.Create(uploadFilePath); | ||
| File.Delete(uploadFilePath); | ||
|
|
||
| string pdfFileName = name.Split(".").First() + ".pdf"; |
There was a problem hiding this comment.
I think this needs to handle filenames with multiple periods. Something like
name.Substring(0, name.LastIndexOf('.'))
| "label": "Settings" | ||
| }, | ||
| "reload":{ | ||
| "label": "Reload Folder" |
There was a problem hiding this comment.
In French:
"label": "Recharger le dossier"
In Spanish:
"label": "Recargar carpeta"
|
|
||
| ```yml | ||
| pdfedit: | ||
| image: ghcr.io/danielhabenicht/danielhabenicht/fork.pdf-web-edit:v0.9.2 |
There was a problem hiding this comment.
Any way we can read this from a variable?
There was a problem hiding this comment.
I don't think so. But if you add something like mkdocs and host it as github page you could autogenerate it.
There was a problem hiding this comment.
Or write a custom action that automatically commits after every release.
|
Hey @DanielHabenicht - really grateful for your work on this 👍. If you could just give me some feedback on my comments then I think I'm happy to get it merged. Apologies for the delay, I did say it may take me a while 😆 |
|
Sorry, I am also quite busy. I will try to add the changes this week (and address the bug from #54) |
2 participants
This fixes or improves and implements various cases (sorry for filing only one PR), feel free to cherry pick or just copy what you need):
I can help however you like, just that I don't want to have too much time.
Currently I am still testing this on my homelab.