fix: should not set "Content-Encoding" for a direct request of a compressed file#161
Open
hi-ogawa wants to merge 5 commits intolukeed:mainfrom
Open
Conversation
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content-Encodingshould be used only when sirv is serving pre-compressed files (e.g. request: test.csv --> response: test.csv.gz), but it should be avoided when users are requesting a compressed file directly (e.g. test.csv.gz).Citing from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding
The summary of changes in this PR is:
extns: stringwithextns: { ext: string, encoded: boolean }[],viaLocalorviaCache, it also returns{ name: string, encoded: boolean }Content-TypeandContent-Encodinghandling fromtoHeaderstosendsince it now requiresnameandencodedto decide these two headers.Diff looks a little involved, but I hope this is clear and correct. I would appreciate a review. Thanks!