Skip to content

LUM-1117, LUM-1118: Implement Job fees mechanism #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shyam-patel-kira wants to merge 43 commits into from
Closed

LUM-1117, LUM-1118: Implement Job fees mechanism #19

shyam-patel-kira wants to merge 43 commits into from

Conversation

@shyam-patel-kira
Copy link
Member

@shyam-patel-kira shyam-patel-kira commented Dec 2, 2024 •
edited
Loading

Notes and changes

  • Implement job fees mechanism
    • Now whenever a CP completes the job, it'll be rewarded the fee associated with that job
  • JobsManager can now access StakeManager state and vice versa
    • This was needed because the fees and stake is locked in the stakeManager contract and job completion is handled in JobsManager
  • Delete the unnecessary lib files

Testing

  • deployed jobsManager and stakeManager manually, test the transfer funds from one account to another

@shyam-patel-kira shyam-patel-kira added the enhancement New feature or request label Dec 2, 2024
@shyam-patel-kira shyam-patel-kira self-assigned this Dec 2, 2024
@linear
Copy link

linear bot commented Dec 2, 2024

LUM-1117 connect stakeManager and jobsManager contract

LUM-1118 Reward fees to compute provider that completes the job

@shyam-patel-kira shyam-patel-kira changed the title LUM-1117, LUM-1118: Connect stakeManager and jobManager LUM-1117, LUM-1118: Implement rewards fee mechanism Dec 2, 2024
@shyam-patel-kira
differentiate roles from single admin role
6e97a14
@shyam-patel-kira
nit: spacing
f86c467
@shyam-patel-kira
Add github actions config for the repo
2bef8fd
@shyam-patel-kira
Update .gitignore
ce1ce25
@shyam-patel-kira
add prettier config; package contract in yarn
7774cf5
@shyam-patel-kira
run CI on PR
708182e
@shyam-patel-kira
rename the repo secret
ca373ad
@shyam-patel-kira
Update Constants.sol
5825350
@shyam-patel-kira
Merge pull request #20 from luminolabs/feat/add-roles
5b111a1 
LUM-1119: Setup roles for contracts
@shyam-patel-kira
Merge branch 'feat/stakeTokens' of https://github.com/luminolabs/cont…
ee9a871 
…racts into feat/github-actions
@shyam-patel-kira
fix testcases for jobs and stake manager
60df4fd
@shyam-patel-kira
keep version to prevent warning and build error
de14346
@shyam-patel-kira
Update solidity version
8cd48ff
@shyam-patel-kira
add slither report to .gitignore
e1e1cf5
@shyam-patel-kira
run forge build before running slither checks
f8ecb51
@shyam-patel-kira
Add deployment to the pipeline
f2afaba
@shyam-patel-kira
add remappings for correctly using imports
485fe24
@shyam-patel-kira
Update imports to not use relative path
3b88a0a
@shyam-patel-kira
Update imports to not use relative path
44ac481
@shyam-patel-kira
Update gitmodules and method for dependency installation
206fa4f
@shyam-patel-kira
remove default module
5781b00
@shyam-patel-kira shyam-patel-kira changed the title LUM-1117, LUM-1118: Implement rewards fee mechanism LUM-1117, LUM-1118: Implement Job fees mechanism Dec 20, 2024
yogeshdarji
yogeshdarji reviewed Dec 20, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vasrap vasrap Awaiting requested review from vasrap

@yogeshdarji yogeshdarji Awaiting requested review from yogeshdarji

Assignees

@shyam-patel-kira shyam-patel-kira

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shyam-patel-kira @yogeshdarji