Skip to content

Conversation

@shyam-patel-kira
Copy link
Member

Notes and changes

  • Implement job fees mechanism
    • Now whenever a CP completes the job, it'll be rewarded the fee associated with that job
  • JobsManager can now access StakeManager state and vice versa
    • This was needed because the fees and stake is locked in the stakeManager contract and job completion is handled in JobsManager
  • Delete the unnecessary lib files

Testing

  • deployed jobsManager and stakeManager manually, test the transfer funds from one account to another

@linear
Copy link

linear bot commented Jan 6, 2025

@shyam-patel-kira shyam-patel-kira added the enhancement New feature or request label Jan 6, 2025
@shyam-patel-kira shyam-patel-kira merged commit dbdfca2 into develop Jan 8, 2025
8 checks passed
shyam-patel-kira added a commit that referenced this pull request Jan 9, 2025
* remove initial files

* Add unit tests for ACL.sol

* Increase stateManager coverage to 100%

* Increase jobsManager UT coverage

* fix failing testcase for stateManager

* Increase stakeManager UT coverage

* restrict initializer's visibility to view

* skip deployment script in UT coverage

* LUM-1117, LUM-1118: Implement Job fees mechanism (#23)

* update .gitignore for repomix

* connect stakeManager and JobsManager to use proxy addresses

* Update deployment script

* differentiate roles from single admin role

* nit: spacing

* Add github actions config for the repo

* Update .gitignore

* add prettier config; package contract in yarn

* run CI on PR

* rename the repo secret

* Update Constants.sol

* fix testcases for jobs and stake manager

* keep version to prevent warning and build error

* Update solidity version

* add slither report to .gitignore

* run forge build before running slither checks

* Add deployment to the pipeline

* add remappings for correctly using imports

* Update imports to not use relative path

* Update imports to not use relative path

* Update gitmodules and method for dependency installation

* remove default module

* fix testcases that were broken

* Add gas snapshot; update config

* don't exit procses on snapshot

* remove codecov app

* remove --use solc; update .gitignore

* fix indent

* remove debug flag

* nit: stlye

* remove codecov app

* Add remappings.txt

* Update upgradable contracts version

* remove remappings forge

* reinitialize mappings

* remove uploading sarif file

* remove lib from git repo

* add lib to repo

* reset readme

* remove initial files

* revert overwritten changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants