-
Notifications
You must be signed in to change notification settings - Fork 1
LUM-1117, LUM-1118: Implement Job fees mechanism #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LUM-1119: Setup roles for contracts
…racts into feat/github-actions
LUM-1078: Add Github Actions for contracts
yogeshdarji
approved these changes
Jan 7, 2025
shyam-patel-kira
added a commit
that referenced
this pull request
Jan 9, 2025
* remove initial files * Add unit tests for ACL.sol * Increase stateManager coverage to 100% * Increase jobsManager UT coverage * fix failing testcase for stateManager * Increase stakeManager UT coverage * restrict initializer's visibility to view * skip deployment script in UT coverage * LUM-1117, LUM-1118: Implement Job fees mechanism (#23) * update .gitignore for repomix * connect stakeManager and JobsManager to use proxy addresses * Update deployment script * differentiate roles from single admin role * nit: spacing * Add github actions config for the repo * Update .gitignore * add prettier config; package contract in yarn * run CI on PR * rename the repo secret * Update Constants.sol * fix testcases for jobs and stake manager * keep version to prevent warning and build error * Update solidity version * add slither report to .gitignore * run forge build before running slither checks * Add deployment to the pipeline * add remappings for correctly using imports * Update imports to not use relative path * Update imports to not use relative path * Update gitmodules and method for dependency installation * remove default module * fix testcases that were broken * Add gas snapshot; update config * don't exit procses on snapshot * remove codecov app * remove --use solc; update .gitignore * fix indent * remove debug flag * nit: stlye * remove codecov app * Add remappings.txt * Update upgradable contracts version * remove remappings forge * reinitialize mappings * remove uploading sarif file * remove lib from git repo * add lib to repo * reset readme * remove initial files * revert overwritten changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes and changes
JobsManagercan now accessStakeManagerstate and vice versastakeManagercontract and job completion is handled in JobsManagerTesting
jobsManagerandstakeManagermanually, test the transfer funds from one account to another