Skip to content

Conversation

@shyam-patel-kira
Copy link
Member

Description:

  • Added more tests for StateManager, StakeManager and JobsManager.
  • Added new tests for ACL
  • Add simulations to StateManager for testing stateTransition

Testing

forge build --skip script/DeployUpgradeableLuminoProtocol.s.sol 

# for running these tests
forge test -vv

# for coverage
forge coverage --skip script/DeployUpgradeableLuminoProtocol.s.sol 

Current Coverage

Ran 4 test suites in 124.34ms (20.99ms CPU time): 34 tests passed, 0 failed, 0 skipped (34 total tests)
| File                      | % Lines          | % Statements     | % Branches      | % Funcs         |
|---------------------------|------------------|------------------|-----------------|-----------------|
| src/Core/ACL.sol          | 100.00% (1/1)    | 100.00% (1/1)    | 100.00% (0/0)   | 100.00% (1/1)   |
| src/Core/JobsManager.sol  | 92.42% (61/66)   | 91.03% (71/78)   | 57.14% (24/42)  | 88.89% (8/9)    |
| src/Core/StakeManager.sol | 100.00% (35/35)  | 100.00% (38/38)  | 80.77% (21/26)  | 100.00% (10/10) |
| src/Core/StateManager.sol | 100.00% (11/11)  | 100.00% (19/19)  | 100.00% (10/10) | 100.00% (5/5)   |
| Total                     | 95.58% (108/113) | 94.85% (129/136) | 70.51% (55/78)  | 96.00% (24/25)  |

@linear
Copy link

linear bot commented Jan 6, 2025

* update .gitignore for repomix

* connect stakeManager and JobsManager to use proxy addresses

* Update deployment script

* differentiate roles from single admin role

* nit: spacing

* Add github actions config for the repo

* Update .gitignore

* add prettier config; package contract in yarn

* run CI on PR

* rename the repo secret

* Update Constants.sol

* fix testcases for jobs and stake manager

* keep version to prevent warning and build error

* Update solidity version

* add slither report to .gitignore

* run forge build before running slither checks

* Add deployment to the pipeline

* add remappings for correctly using imports

* Update imports to not use relative path

* Update imports to not use relative path

* Update gitmodules and method for dependency installation

* remove default module

* fix testcases that were broken

* Add gas snapshot; update config

* don't exit procses on snapshot

* remove codecov app

* remove --use solc; update .gitignore

* fix indent

* remove debug flag

* nit: stlye

* remove codecov app

* Add remappings.txt

* Update upgradable contracts version

* remove remappings forge

* reinitialize mappings

* remove uploading sarif file

* remove lib from git repo

* add lib to repo

* reset readme

* remove initial files
@shyam-patel-kira shyam-patel-kira merged commit 8bebfa1 into feat/stakeTokens Jan 9, 2025
4 checks passed
shyam-patel-kira added a commit that referenced this pull request Jan 9, 2025
@shyam-patel-kira shyam-patel-kira deleted the testing/UT-coverage branch February 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants