Skip to content

Conversation

@shyam-patel-kira
Copy link
Member

@shyam-patel-kira shyam-patel-kira commented Jan 9, 2025

Changes

  • Add Whitelist contract
    • functions for adding and removing batch of addresses
  • Added Unit Tests for the same
  • Added whitelist contract to deployment script

Testing

  • Tested by deploying the contract on a local blockchain
  • For running unit tests and coverage
forge build --skip script/DeployUpgradeableLuminoProtocol.s.sol
forge test --vv
forge coverage --skip script/DeployUpgradeableLuminoProtocol.s.sol 

Current Coverage:

Ran 5 test suites in 119.94ms (21.59ms CPU time): 45 tests passed, 0 failed, 0 skipped (45 total tests)
| File                      | % Lines          | % Statements     | % Branches      | % Funcs         |
|---------------------------|------------------|------------------|-----------------|-----------------|
| src/Core/ACL.sol          | 100.00% (1/1)    | 100.00% (1/1)    | 100.00% (0/0)   | 100.00% (1/1)   |
| src/Core/JobsManager.sol  | 92.42% (61/66)   | 91.03% (71/78)   | 57.14% (24/42)  | 88.89% (8/9)    |
| src/Core/StakeManager.sol | 100.00% (35/35)  | 100.00% (38/38)  | 80.77% (21/26)  | 100.00% (10/10) |
| src/Core/StateManager.sol | 100.00% (11/11)  | 100.00% (19/19)  | 100.00% (10/10) | 100.00% (5/5)   |
| src/Core/Whitelist.sol    | 95.24% (40/42)   | 95.45% (42/44)   | 68.42% (26/38)  | 87.50% (7/8)    |
| Total                     | 93.08% (148/159) | 92.93% (171/184) | 68.64% (81/118) | 88.57% (31/35)  |

@shyam-patel-kira shyam-patel-kira added the enhancement New feature or request label Jan 9, 2025
@shyam-patel-kira shyam-patel-kira self-assigned this Jan 9, 2025
@linear
Copy link

linear bot commented Jan 9, 2025

LUM-1277 Research and design whitelisting on contracts side

  • Come up with a design for whitelist contract
  • Implement Whitelisting contract

@shyam-patel-kira shyam-patel-kira changed the title LUM-1277: Implement WhiteListing on Contracts side LUM-1277: Implement PoC WhiteListing on Contracts side Jan 9, 2025
@shyam-patel-kira shyam-patel-kira changed the base branch from testing/UT-coverage to develop January 15, 2025 19:20
@shyam-patel-kira shyam-patel-kira merged commit a0236be into develop Jan 15, 2025
4 checks passed
@shyam-patel-kira shyam-patel-kira deleted the feat/whitelist branch February 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants