fix(deserialization): nested deserialization (#200)#203
Closed
BSchneppe wants to merge 6 commits intoluminvent:mainfrom
Closed
fix(deserialization): nested deserialization (#200)#203BSchneppe wants to merge 6 commits intoluminvent:mainfrom
BSchneppe wants to merge 6 commits intoluminvent:mainfrom
Conversation
changes condition of start element next_event call for structs, always break for EndDocument
Author
|
was not able to reproduce the deserialization result seen in |
Contributor
|
I close as I have rebase and create a new PR here #212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes condition of start element next_event call for structs
always break for EndDocument
fixes #200
This kind of conflicts with #193, and we probably need to come up with a different solution. The problem is that we compare the name of the struct here with the local name, which will not work for renamed fields