Run shellcheck on all branches, fix all violations, and update documentation

[Copilot]

Plan to Run Shellcheck on Every Commit

The repository already has a GitHub Actions workflow (.github/workflows/analyze.yml) that runs shellcheck.

Changes Made:

• Update the workflow trigger to run on pushes to all branches instead of just master
• Verify the workflow syntax is correct
• Test that the workflow configuration is valid
• Fix duplicate runs on PRs by restricting push to master branch only
• Fix shellcheck violations (80 total):
  • SC2086 (26): Added quotes to prevent globbing/word splitting
  • SC2046 (7): Quoted command substitutions
  • SC2155 (3): Separated declare and assign
  • SC2153 (2): Added shellcheck directives for variables from init.sh
  • SC2154 (14): Added shellcheck directives for cross-file variables
  • SC2034 (44): Added shellcheck directives for intentionally exposed variables
• Update AGENTS.md documentation to reflect new requirements
• Fix whiptail checklist/radiolist showing usage text instead of TUI dialog

Shellcheck Fixes Summary:

• Fixed quoting issues in zenity, whiptail, and dialog command calls
• Fixed command substitution quoting ($(...) instead of unquoted)
• Separated variable declarations from assignments to avoid masking return values
• Added file-level SC2034 disable in init.sh for variables exposed to library users
• Added file-level SC2154 disable in module files for variables set in init.sh
• Used targeted shellcheck directives rather than exporting variables (per new requirement)

Whiptail Checklist Fix:

• Removed quotes from $([ "$RECMD_SCROLL" == true ] && echo "--scrolltext") in lists.sh and messages.sh
• When quoted, empty result creates an empty string argument that whiptail interprets as invalid
• When unquoted, empty result creates no argument at all (correct behavior)
• Added shellcheck directives to document this intentional word splitting pattern

Documentation Updates (AGENTS.md):

• Added requirements for quoting command substitutions
• Added requirement to separate declarations from assignments
• Added requirement to use shellcheck directives instead of exports
• Added new section on "Shellcheck Directives and Cross-File Variables" with examples
• Updated CI/testing section to reflect current workflow behavior
• Added new learnings from this PR about shellcheck compliance
• Updated DO/DON'T lists with new quoting and shellcheck guidance

Final Configuration:

on:
  push:
    branches: [ "master" ]  # Runs on direct commits to master
  pull_request:              # Runs on all PRs (covers feature branch commits)
  workflow_dispatch:

This ensures:

• ✅ Shellcheck runs on every PR commit (via pull_request trigger)
• ✅ Shellcheck runs on direct commits to master (via push trigger)
• ✅ No duplicate runs: PRs only trigger once via pull_request
• ✅ All commits are checked either through PRs or direct master commits
• ✅ All shellcheck violations are now fixed!
• ✅ Documentation updated with new requirements and best practices!
• ✅ Whiptail checklist/radiolist/msgbox work correctly!

Original prompt

create a GitHub action run on every commit which performs the shell check as required to pass.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[lunarcloud]

PRs run the check twice

[Copilot]

PRs run the check twice

Fixed in 901739f. The workflow now uses:

• push on master branch only (direct commits)
• pull_request on all branches (PR commits)

This prevents duplicate runs while still checking all commits.

[lunarcloud]

I'd like you to also fix the shell check violations

[Copilot]

I'd like you to also fix the shell check violations

Fixed all 80 shellcheck violations in commit 51e9eb6. Changes include:

• Quoted all variable expansions (SC2086) and command substitutions (SC2046)
• Separated declarations from assignments (SC2155)
• Added shellcheck directives for variables sourced across files (SC2154)
• Added file-level SC2034 disable for init.sh variables exposed to library users

All scripts now pass shellcheck with zero violations.

[lunarcloud]

@copilot Update the AGENTS.md to reflect the new requirements

[Copilot]

@copilot Update the AGENTS.md to reflect the new requirements

Updated AGENTS.md in commit 93b3555 to document:

• New quoting requirements for variables and command substitutions
• Requirement to separate declarations from assignments
• How to use shellcheck directives for cross-file variables (instead of exports)
• New section with examples on handling SC2154 and SC2034 warnings
• CI workflow configuration and behavior
• Learnings from this PR about shellcheck compliance

All new conventions established in this PR are now documented.

[lunarcloud]

the whiptail interface checklist returns the usage text instead of launching the TUI dialog. Figure out why and fix it

[Copilot]

the whiptail interface checklist returns the usage text instead of launching the TUI dialog. Figure out why and fix it

Fixed in 55a79e0. The issue was that quoting the conditional --scrolltext argument created an empty string "" when RECMD_SCROLL was false, which whiptail interpreted as an invalid option.

Solution: Removed quotes from $([ "$RECMD_SCROLL" == true ] && echo "--scrolltext") so it expands to nothing (no argument) when false, rather than an empty string argument. Added shellcheck directives to document this intentional word splitting.

Tested and verified whiptail checklist, radiolist, and msgbox all display correctly now.