You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Kept loading rendering width-safe at small terminal sizes.
User value
Large local history scans now show useful progress context instead of a mostly blank waiting screen.
Scope
TUI loading screen only.
No parser/report output contract changes.
Changed files
internal/tui/tui.go
internal/tui/tui_test.go
internal/i18n/i18n.go
Test plan
go test ./internal/tui -run 'TestLoading(RenderWithinTerminalWidth|RenderShowsPhaseCacheAndSourceCounts|RenderClampsProgressPastTotal|SourceCountsUsesCacheAndPathFallback)|TestViewsRenderWithinTerminalWidth|TestViewsFitVerySmallTerminalBounds' -count=1\n- go test ./...\n- go build -o /tmp/agenttrace-parser-check ./cmd/agenttrace\n- /tmp/agenttrace-parser-check --doctor\n- /tmp/agenttrace-parser-check --demo --overview -f json\n\n## Capture notes\n- Normal loading capture coverage: TestLoadingRenderShowsPhaseCacheAndSourceCounts at 120 columns.\n- Narrow loading capture coverage: TestLoadingRenderWithinTerminalWidth across 32, 40, 52, 60, and 80 columns.\n\n## Fixture/privacy note\nUses synthetic TUI fixture state and local smoke commands only. No private session data added.\n\n## Risk\nLow. Source counts are display-only and use cached session source when available, otherwise path-based source buckets.\n\n## Non-goals\n- No changes to discovery, parsing, cache file format, or report schemas.\n- No new persistence fields.\n\n## Blackboard events\n- issue [TUI] Improve large-history loading state and cache progress #143 claimed and moved to in-progress.\n- implementation pushed on parser/143-loading-progress.\n\n## Release impact\nPatch-level TUI usability improvement.\n\n## Handoff suggestion\nReview loading copy and source-count presentation, then merge if CI is green.
Event: Handoff
Actor: Product
Scope: PR #159 / Issue #143
State change: PR labels added lane/product,status/ready-for-review
Evidence: PR #159 closes #143, changes only TUI/i18n/test files, CI Test and build is SUCCESS, and issue #143 records validation for phase/cache/source-count loading context across normal and narrow terminal widths.
Next owner: Quality
Handoff to: Quality
Reason: This is a product/TUI loading-state usability implementation and needs normal Quality review before merge.
Expected output: Review loading-state rendering risk, source-count display logic, terminal-width coverage, and confirm no parser/cache/report contract changes.
Acceptance check: Quality verdict recorded on PR; if PASS, merge can close #143 and candidate patch notes can mention large-history loading progress context.
Decision: PASS. Scope is display-only loading progress context, linked to #143, covered by focused TUI tests plus full local test/build/smoke validation. Proceeding with squash auto-merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Summary
User value
Large local history scans now show useful progress context instead of a mostly blank waiting screen.
Scope
Changed files
Test plan